From 9c60de9b5739d335fe83042d5e40bcdb29389814 Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Thu, 23 Sep 2021 09:58:41 +0200 Subject: [PATCH] panvk: Avoid allocating sysvals UBOs when the pipeline has one The static sysval UBO attached to the pipeline will be used anyway, so let's not waste memory for sysvals if we can avoid it. Signed-off-by: Boris Brezillon Reviewed-by: Tomeu Vizoso Part-of: --- src/panfrost/vulkan/panvk_vX_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_vX_cmd_buffer.c b/src/panfrost/vulkan/panvk_vX_cmd_buffer.c index 7ce34ff24ee..65aee5b81ff 100644 --- a/src/panfrost/vulkan/panvk_vX_cmd_buffer.c +++ b/src/panfrost/vulkan/panvk_vX_cmd_buffer.c @@ -326,7 +326,7 @@ panvk_cmd_prepare_sysvals(struct panvk_cmd_buffer *cmdbuf, for (unsigned i = 0; i < ARRAY_SIZE(desc_state->sysvals); i++) { unsigned sysval_count = pipeline->sysvals[i].ids.sysval_count; - if (!sysval_count || + if (!sysval_count || pipeline->sysvals[i].ubo || (desc_state->sysvals[i] && !(cmdbuf->state.dirty & pipeline->sysvals[i].dirty_mask))) continue;