From 9a53cca85a09f7fc2187c6e047bcd41832dd3424 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 23 Aug 2023 13:22:29 +0200 Subject: [PATCH] panfrost: do not open-code panfrost_has_fragment_job() panfrost_batch_submit() already has an has_fragment_job() at the beginning of the function. Store the result in a local has_frag variable and replace the open-coded test by an 'if (has_frag)'. Signed-off-by: Erik Faye-Lund Reviewed-by: Boris Brezillon Part-of: --- src/gallium/drivers/panfrost/pan_job.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/gallium/drivers/panfrost/pan_job.c b/src/gallium/drivers/panfrost/pan_job.c index d483b76a7ae..4f5f77455da 100644 --- a/src/gallium/drivers/panfrost/pan_job.c +++ b/src/gallium/drivers/panfrost/pan_job.c @@ -789,7 +789,9 @@ panfrost_batch_submit(struct panfrost_context *ctx, if (!batch->scoreboard.first_job && !batch->clear) goto out; - if (batch->key.zsbuf && panfrost_has_fragment_job(batch)) { + bool has_frag = panfrost_has_fragment_job(batch); + + if (batch->key.zsbuf && has_frag) { struct pipe_surface *surf = batch->key.zsbuf; struct panfrost_resource *z_rsrc = pan_resource(surf->texture); @@ -823,7 +825,7 @@ panfrost_batch_submit(struct panfrost_context *ctx, screen->vtbl.emit_tls(batch); panfrost_emit_tile_map(batch, &fb); - if (batch->scoreboard.first_tiler || batch->clear) + if (has_frag) screen->vtbl.emit_fbd(batch, &fb); ret = panfrost_batch_submit_jobs(batch, &fb, 0, ctx->syncobj);