From 936da3eb9c00fec2d61638863ba386009a00f099 Mon Sep 17 00:00:00 2001 From: Tomeu Vizoso Date: Tue, 12 Nov 2024 15:48:54 +0100 Subject: [PATCH] etnaviv/ml: Zero out the NN config As some bits were being left unitialized and causing flakiness. Reviewed-by: Philipp Zabel Part-of: --- src/gallium/drivers/etnaviv/etnaviv_ml_nn.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/src/gallium/drivers/etnaviv/etnaviv_ml_nn.c b/src/gallium/drivers/etnaviv/etnaviv_ml_nn.c index fbab484b474..ba4070dcd7d 100644 --- a/src/gallium/drivers/etnaviv/etnaviv_ml_nn.c +++ b/src/gallium/drivers/etnaviv/etnaviv_ml_nn.c @@ -646,6 +646,7 @@ create_nn_config(struct etna_ml_subgraph *subgraph, const struct etna_operation etna_bo_cpu_prep(bo, DRM_ETNA_PREP_WRITE); struct etna_nn_params *map = etna_bo_map(bo); + memset(map, 0, sizeof(*map)); map->layer_type = 0x0; map->no_z_offset = nn_core_version == 8; map->prelu = 0x0; @@ -733,11 +734,6 @@ create_nn_config(struct etna_ml_subgraph *subgraph, const struct etna_operation map->unused7_2 = nn_core_version == 8; map->unused7_3 = nn_core_version == 8; } - } else { - map->in_image_x_offset = 0x0; - map->in_image_y_offset = 0x0; - map->in_image_x_offset_bit_3 = 0x0; - map->in_image_y_offset_bit_3 = 0x0; } struct pipe_resource *output = etna_ml_get_tensor(subgraph, operation->output_tensor);