From 8939d477ac98e2e69abc0410412ba70d48fc4149 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Fri, 14 Oct 2022 23:04:28 -0700 Subject: [PATCH] zink: Remove duplicate variable zm. Fix defect reported by Coverity Scan. Evaluation order violation (EVALUATION_ORDER) write_write_typo: In zm = zm = create_shader_module_for_stage_optimal(ctx, screen, prog->shaders[i], prog, i, state), zm is written twice with the same value. Fixes: 325c703624a ("zink: add 'optimal_keys' handling for shader keys") Signed-off-by: Vinson Lee Reviewed-by: Erik Faye-Lund Part-of: --- src/gallium/drivers/zink/zink_program.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/zink/zink_program.c b/src/gallium/drivers/zink/zink_program.c index 776092a3e50..6102ee4cd0a 100644 --- a/src/gallium/drivers/zink/zink_program.c +++ b/src/gallium/drivers/zink/zink_program.c @@ -441,7 +441,7 @@ generate_gfx_program_modules_optimal(struct zink_context *ctx, struct zink_scree assert(prog->shaders[i]); - struct zink_shader_module *zm = zm = create_shader_module_for_stage_optimal(ctx, screen, prog->shaders[i], prog, i, state); + struct zink_shader_module *zm = create_shader_module_for_stage_optimal(ctx, screen, prog->shaders[i], prog, i, state); prog->modules[i] = zm->shader; }