From 8680bf0cb1b0e1ae6fae9c42abc55bb192c4978e Mon Sep 17 00:00:00 2001 From: Faith Ekstrand Date: Tue, 19 Aug 2025 11:45:00 -0400 Subject: [PATCH] nouveau/class_parser: Stop shifting by zero This a clippy warning and generates piles of spam Reviewed-by: Karol Herbst Part-of: --- src/nouveau/headers/class_parser.py | 26 +++++++++++++------------- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/src/nouveau/headers/class_parser.py b/src/nouveau/headers/class_parser.py index 011d6110a00..2786f5adf31 100644 --- a/src/nouveau/headers/class_parser.py +++ b/src/nouveau/headers/class_parser.py @@ -312,20 +312,20 @@ impl ArrayMthd for ${to_camel(mthd.name)} { let mut val = 0; %for field in mthd.fields: <% field_width = field.end - field.start + 1 %> - %if field_width == 32: - %if field.rs_type(mthd) == "u32": - val |= self.${field.rs_name}; - %else: - val |= self.${field.rs_name} as u32; - %endif + %if field.rs_type(mthd) == "u32": + let field_u32 = self.${field.rs_name}; %else: - %if field.rs_type(mthd) == "u32": - assert!(self.${field.rs_name} < (1 << ${field_width})); - val |= self.${field.rs_name} << ${field.start}; - %else: - assert!((self.${field.rs_name} as u32) < (1 << ${field_width})); - val |= (self.${field.rs_name} as u32) << ${field.start}; - %endif + let field_u32 = self.${field.rs_name} as u32; + %endif + %if field_width == 32: + <% assert field_width == 32 %> + %else: + assert!(field_u32 < (1 << ${field_width})); + %endif + %if field.start == 0: + val |= field_u32; + %else: + val |= field_u32 << ${field.start}; %endif %endfor