From 83f53be8c712353cc8e0544c5d85b2b398647d08 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Tue, 19 Mar 2024 13:37:45 +0100 Subject: [PATCH] broadcom/ci: add skips for unsupported features Currently 92% of our Vulkan CI tests hit "Not Supported" test cases, which is ridiculously high. Add a bunch of skips, some of which include very large categories of tests of features we already know we don't support, so we stop wasting so much time skipping tests. With this, we can also increase the fraction of tests we execute for vulkan significantly, while still keeping job run times under control. Reviewed-by: Juan A. Suarez Part-of: --- src/broadcom/ci/broadcom-rpi4-skips.txt | 20 ++++++++++++++++---- src/broadcom/ci/broadcom-rpi5-skips.txt | 20 ++++++++++++++++---- src/broadcom/ci/gitlab-ci.yml | 2 +- 3 files changed, 33 insertions(+), 9 deletions(-) diff --git a/src/broadcom/ci/broadcom-rpi4-skips.txt b/src/broadcom/ci/broadcom-rpi4-skips.txt index 287b2e30fda..280a6d3ac5c 100644 --- a/src/broadcom/ci/broadcom-rpi4-skips.txt +++ b/src/broadcom/ci/broadcom-rpi4-skips.txt @@ -285,10 +285,22 @@ dEQP-VK.wsi.xlib.maintenance1.present_fence.mailbox.multi_swapchain dEQP-VK.wsi.xlib.swapchain.simulate_oom.image_usage dEQP-VK.wsi.xlib.swapchain.simulate_oom.min_image_count -# These require VK_EXT_shader_object but not all of them check for it -# (Seems fixed in CTS main) -dEQP-VK.pipeline.shader_object* - # These require VK_KHR_shader_draw_parameters but they don't check for it # (Seems to be fixed in some later release of CTS 1.3.7). dEQP-VK.draw.dynamic_rendering.primary_cmd_buff.multi_draw.* + +# Skip tests for unsupported features so we can increase the number of tests +# that are actually useful in the limited CI time we have per job. +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.* +dEQP-VK.pipeline.monolithic.bind_point.graphics_raytracing.* +dEQP-VK.pipeline.monolithic.bind_point.compute_raytracing.* +dEQP-VK.pipeline.pipeline_library.* +dEQP-VK.pipeline.fast_linked_library.* +dEQP-VK.pipeline.shader_object* +dEQP-VK.protected_memory.* +dEQP-VK.transform_feedback.* +dEQP-VK.ray_tracing_pipeline.* +dEQP-VK.ray_query.* +dEQP-VK.fragment_shading_rate.* +dEQP-VK.mesh_shader.* +dEQP-VK.shader_object.rendering.* diff --git a/src/broadcom/ci/broadcom-rpi5-skips.txt b/src/broadcom/ci/broadcom-rpi5-skips.txt index 3bee4a5d566..d9e430dff0f 100644 --- a/src/broadcom/ci/broadcom-rpi5-skips.txt +++ b/src/broadcom/ci/broadcom-rpi5-skips.txt @@ -75,10 +75,22 @@ dEQP-VK.wsi.wayland.incremental_present.scale_none.fifo.identity.opaque.referenc dEQP-VK.wsi.wayland.incremental_present.scale_none.fifo.identity.pre_multiplied.incremental_present dEQP-VK.wsi.wayland.incremental_present.scale_none.fifo.identity.pre_multiplied.reference -# These require VK_EXT_shader_object but not all of them check for it -# (Seems fixed in CTS main) -dEQP-VK.pipeline.shader_object* - # These require VK_KHR_shader_draw_parameters but they don't check for it # (Seems to be fixed in some later release of CTS 1.3.7). dEQP-VK.draw.dynamic_rendering.primary_cmd_buff.multi_draw.* + +# Skip tests for unsupported features so we can increase the number of tests +# that are actually useful in the limited CI time we have per job. +dEQP-VK.pipeline.monolithic.multisample_with_fragment_shading_rate.* +dEQP-VK.pipeline.monolithic.bind_point.graphics_raytracing.* +dEQP-VK.pipeline.monolithic.bind_point.compute_raytracing.* +dEQP-VK.pipeline.pipeline_library.* +dEQP-VK.pipeline.fast_linked_library.* +dEQP-VK.pipeline.shader_object* +dEQP-VK.protected_memory.* +dEQP-VK.transform_feedback.* +dEQP-VK.ray_tracing_pipeline.* +dEQP-VK.ray_query.* +dEQP-VK.fragment_shading_rate.* +dEQP-VK.mesh_shader.* +dEQP-VK.shader_object.rendering.* diff --git a/src/broadcom/ci/gitlab-ci.yml b/src/broadcom/ci/gitlab-ci.yml index 60135807697..32ef88554fc 100644 --- a/src/broadcom/ci/gitlab-ci.yml +++ b/src/broadcom/ci/gitlab-ci.yml @@ -70,7 +70,7 @@ v3dv-rpi4-vk:arm64: HWCI_TEST_SCRIPT: "/install/deqp-runner.sh" HWCI_START_WESTON: 1 DEQP_EXPECTED_RENDERER: "V3D.4.2" - DEQP_FRACTION: 9 + DEQP_FRACTION: 3 DEQP_VER: vk FLAKES_CHANNEL: "#videocore-ci"