From 828c7e76267b6bccd284aa4de4d518d87393780f Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Sat, 31 Oct 2020 10:25:07 -0400 Subject: [PATCH] panfrost: Disable point sprites on Bifrost It doesn't look like the lowering in !6473 will land before the branch point. Let's nop out point sprites in the backend to avoid MMU faults from creating invalid Midgard-style varyings. Signed-off-by: Alyssa Rosenzweig Reviewed-by: Boris Brezillon Part-of: --- src/gallium/drivers/panfrost/pan_cmdstream.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/panfrost/pan_cmdstream.c b/src/gallium/drivers/panfrost/pan_cmdstream.c index 645047fb816..0653db31c2b 100644 --- a/src/gallium/drivers/panfrost/pan_cmdstream.c +++ b/src/gallium/drivers/panfrost/pan_cmdstream.c @@ -1720,6 +1720,11 @@ panfrost_emit_varying_descriptor(struct panfrost_batch *batch, struct pipe_stream_output_info *so = &vs->stream_output; uint16_t point_coord_mask = ctx->rasterizer->base.sprite_coord_enable; + + /* TODO: point sprites need lowering on Bifrost */ + if (dev->quirks & IS_BIFROST) + point_coord_mask = 0; + unsigned present = pan_varying_present(vs, fs, dev->quirks, point_coord_mask); /* Check if this varying is linked by us. This is the case for