From 7eda433095b2f637490969965724bd829bd21f7e Mon Sep 17 00:00:00 2001
From: Benjamin Lee <benjamin.lee@collabora.com>
Date: Tue, 12 Nov 2024 16:45:55 -0800
Subject: [PATCH] nir: document order requirement for
 nir_lower_viewport_transform

This requirement is currently satisfied by the usage in panfrost and
lima.

Signed-off-by: Benjamin Lee <benjamin.lee@collabora.com>
Reviewed-by: Erik Faye-Lund <erik.faye-lund@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/32084>
---
 src/compiler/nir/nir_lower_viewport_transform.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/compiler/nir/nir_lower_viewport_transform.c b/src/compiler/nir/nir_lower_viewport_transform.c
index 9500ba2cbbc..00bc90f9801 100644
--- a/src/compiler/nir/nir_lower_viewport_transform.c
+++ b/src/compiler/nir/nir_lower_viewport_transform.c
@@ -34,7 +34,8 @@
  * "Coordinate Transformation" of the OpenGL ES 3.2 full specification.
  *
  * This pass must run before lower_vars/lower_io such that derefs are
- * still in place.
+ * still in place. This pass must run after lower_io_to_temporaries so
+ * that the transformed position is not visible to user code.
  */
 
 #include "nir/nir.h"