From 754ad73b8be95eb68577644c0faf3a71332404e1 Mon Sep 17 00:00:00 2001
From: David Heidelberg <david.heidelberg@collabora.com>
Date: Thu, 15 Jun 2023 12:07:47 +0200
Subject: [PATCH] ci: fail pipeline for users who got access to restricted
 traces

Broken trace is easier to ignore. Make it a bit harder.

Acked-by: Rob Clark <robdclark@chromium.org>
Signed-off-by: David Heidelberg <david.heidelberg@collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/23674>
---
 .gitlab-ci/test-source-dep.yml            | 3 +++
 src/freedreno/ci/gitlab-ci.yml            | 1 -
 src/gallium/drivers/zink/ci/gitlab-ci.yml | 1 -
 3 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/.gitlab-ci/test-source-dep.yml b/.gitlab-ci/test-source-dep.yml
index 06f21acf5e5..5c50569c6d8 100644
--- a/.gitlab-ci/test-source-dep.yml
+++ b/.gitlab-ci/test-source-dep.yml
@@ -38,6 +38,9 @@
     - if: '($GITLAB_USER_LOGIN !~ "/^(robclark|anholt|flto|cwabbott0|Danil|tomeu|okias|gallo|kwg|majanes|llanderwelin|zmike|vigneshraman)$/") &&
            ($GITLAB_USER_LOGIN != "marge-bot" || $CI_COMMIT_BRANCH)'
       when: never
+    - if: '($GITLAB_USER_LOGIN != "marge-bot" || $CI_COMMIT_BRANCH)' # so it's invoked by user
+      allow_failure: false
+    - allow_failure: true
 
 # Mesa core source file dependencies that may impact any test job
 # ---------------------------------------------------------------
diff --git a/src/freedreno/ci/gitlab-ci.yml b/src/freedreno/ci/gitlab-ci.yml
index 3948ed147d0..16755a73b8a 100644
--- a/src/freedreno/ci/gitlab-ci.yml
+++ b/src/freedreno/ci/gitlab-ci.yml
@@ -269,7 +269,6 @@ a630-traces-restricted:
   variables:
     PIGLIT_TRACES_FILE: restricted-traces-freedreno.yml
     PIGLIT_REPLAY_EXTRA_ARGS: "--download-caching-proxy-url=http://10.42.0.1:8888/cache/?uri= --db-path ${CI_PROJECT_DIR}/replayer-db/ --minio_bucket=${S3_TRACIE_PRIVATE_BUCKET} --jwt-file=${S3_JWT_FILE}"
-  allow_failure: true
 
 a630-traces-performance:
   extends:
diff --git a/src/gallium/drivers/zink/ci/gitlab-ci.yml b/src/gallium/drivers/zink/ci/gitlab-ci.yml
index 9dd5989304a..e7d42f4ebce 100644
--- a/src/gallium/drivers/zink/ci/gitlab-ci.yml
+++ b/src/gallium/drivers/zink/ci/gitlab-ci.yml
@@ -79,7 +79,6 @@ zink-anv-tgl-traces-restricted:
   variables:
     PIGLIT_TRACES_FILE: traces-zink-restricted.yml
     PIGLIT_REPLAY_EXTRA_ARGS: --db-path ${CI_PROJECT_DIR}/replayer-db/ --minio_bucket=${S3_TRACIE_PRIVATE_BUCKET} --jwt-file=${S3_JWT_FILE}
-  allow_failure: true
 
 zink-tu-a618:
   extends: