diff --git a/src/mapi/glapi/gen/ARB_direct_state_access.xml b/src/mapi/glapi/gen/ARB_direct_state_access.xml
index 21bf9acfea6..1d1b5072c20 100644
--- a/src/mapi/glapi/gen/ARB_direct_state_access.xml
+++ b/src/mapi/glapi/gen/ARB_direct_state_access.xml
@@ -375,7 +375,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -386,7 +386,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -399,7 +399,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -414,7 +414,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -425,7 +425,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -438,7 +438,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -530,7 +530,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -540,7 +540,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
diff --git a/src/mapi/glapi/gen/ARB_get_texture_sub_image.xml b/src/mapi/glapi/gen/ARB_get_texture_sub_image.xml
index 7a8df8bd9c1..1325aa9e132 100644
--- a/src/mapi/glapi/gen/ARB_get_texture_sub_image.xml
+++ b/src/mapi/glapi/gen/ARB_get_texture_sub_image.xml
@@ -8,7 +8,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -24,7 +24,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
diff --git a/src/mapi/glapi/gen/ARB_robustness.xml b/src/mapi/glapi/gen/ARB_robustness.xml
index c808eb34ae8..ca1ce7c729d 100644
--- a/src/mapi/glapi/gen/ARB_robustness.xml
+++ b/src/mapi/glapi/gen/ARB_robustness.xml
@@ -69,13 +69,13 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -85,7 +85,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -146,7 +146,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
diff --git a/src/mapi/glapi/gen/EXT_direct_state_access.xml b/src/mapi/glapi/gen/EXT_direct_state_access.xml
index 0f1055c80d2..f087de2473c 100644
--- a/src/mapi/glapi/gen/EXT_direct_state_access.xml
+++ b/src/mapi/glapi/gen/EXT_direct_state_access.xml
@@ -174,7 +174,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -187,7 +187,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -201,7 +201,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -216,7 +216,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -228,7 +228,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -242,7 +242,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -316,7 +316,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -446,7 +446,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -472,7 +472,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -485,7 +485,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -499,7 +499,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -514,7 +514,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -526,7 +526,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -540,7 +540,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -708,7 +708,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -720,7 +720,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -733,7 +733,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -747,7 +747,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -759,7 +759,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -773,7 +773,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -789,7 +789,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -797,7 +797,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -809,7 +809,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -822,7 +822,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -836,7 +836,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -848,7 +848,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -862,7 +862,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -878,7 +878,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
diff --git a/src/mapi/glapi/gen/gl_API.xml b/src/mapi/glapi/gen/gl_API.xml
index d12d33364ac..a22d6ce2085 100644
--- a/src/mapi/glapi/gen/gl_API.xml
+++ b/src/mapi/glapi/gen/gl_API.xml
@@ -2121,7 +2121,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2170,7 +2170,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2183,7 +2183,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2633,7 +2633,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2641,7 +2641,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2649,7 +2649,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -2671,7 +2671,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -2776,28 +2776,28 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -2844,7 +2844,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
@@ -3345,7 +3345,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -3358,7 +3358,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4061,7 +4061,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4076,7 +4076,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4554,7 +4554,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4568,7 +4568,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4581,7 +4581,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4593,7 +4593,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4609,7 +4609,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4623,7 +4623,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_unpack_buffer(ctx)">
@@ -4635,7 +4635,7 @@
+ marshal="async" marshal_sync="!_mesa_glthread_has_pack_buffer(ctx)">
diff --git a/src/mesa/main/glthread_marshal.h b/src/mesa/main/glthread_marshal.h
index 5084301ebbf..b7dbfc35f4b 100644
--- a/src/mesa/main/glthread_marshal.h
+++ b/src/mesa/main/glthread_marshal.h
@@ -137,15 +137,15 @@ _mesa_glthread_call_is_last(struct glthread_state *glthread,
}
static inline bool
-_mesa_glthread_has_no_pack_buffer(const struct gl_context *ctx)
+_mesa_glthread_has_pack_buffer(const struct gl_context *ctx)
{
- return ctx->GLThread.CurrentPixelPackBufferName == 0;
+ return ctx->GLThread.CurrentPixelPackBufferName != 0;
}
static inline bool
-_mesa_glthread_has_no_unpack_buffer(const struct gl_context *ctx)
+_mesa_glthread_has_unpack_buffer(const struct gl_context *ctx)
{
- return ctx->GLThread.CurrentPixelUnpackBufferName == 0;
+ return ctx->GLThread.CurrentPixelUnpackBufferName != 0;
}
static inline unsigned
diff --git a/src/mesa/main/glthread_pixels.c b/src/mesa/main/glthread_pixels.c
index bceef8081dd..5f4836b1cdb 100644
--- a/src/mesa/main/glthread_pixels.c
+++ b/src/mesa/main/glthread_pixels.c
@@ -47,7 +47,7 @@ _mesa_marshal_Bitmap(GLsizei width, GLsizei height, GLfloat xorig,
/* PBO path or bitmap == NULL (which means xmove/ymove only move the raster
* pos.
*/
- if (!bitmap || !_mesa_glthread_has_no_unpack_buffer(ctx)) {
+ if (!bitmap || _mesa_glthread_has_unpack_buffer(ctx)) {
struct marshal_cmd_Bitmap *cmd =
_mesa_glthread_allocate_command(ctx, DISPATCH_CMD_Bitmap,
cmd_size);
@@ -120,7 +120,7 @@ _mesa_marshal_DrawPixels(GLsizei width, GLsizei height, GLenum format,
/* If not building a display list... */
if (!ctx->GLThread.ListMode) {
/* PBO */
- if (!_mesa_glthread_has_no_unpack_buffer(ctx)) {
+ if (_mesa_glthread_has_unpack_buffer(ctx)) {
struct marshal_cmd_DrawPixels *cmd =
_mesa_glthread_allocate_command(ctx, DISPATCH_CMD_DrawPixels,
cmd_size);