From 739a08ad2352f1c10bad623350c1e321d0fbc9af Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Wed, 21 Dec 2022 22:39:29 +0200 Subject: [PATCH] anv: handle null push descriptors in deferred optimization MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Lionel Landwerlin Fixes: b49b18f0 ("anv: reduce BT emissions & surface state writes with push descriptors") Reviewed-by: José Roberto de Souza Part-of: --- src/intel/vulkan/genX_cmd_buffer.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c index 7929c1f535a..e3d256ff653 100644 --- a/src/intel/vulkan/genX_cmd_buffer.c +++ b/src/intel/vulkan/genX_cmd_buffer.c @@ -2362,9 +2362,11 @@ flush_push_descriptor_set(struct anv_cmd_buffer *cmd_buffer, struct anv_descriptor *desc = &set->descriptors[desc_idx]; struct anv_buffer_view *bview = desc->set_buffer_view; - bview->surface_state = anv_cmd_buffer_alloc_surface_state(cmd_buffer); - anv_descriptor_write_surface_state(cmd_buffer->device, desc, - bview->surface_state); + if (bview != NULL) { + bview->surface_state = anv_cmd_buffer_alloc_surface_state(cmd_buffer); + anv_descriptor_write_surface_state(cmd_buffer->device, desc, + bview->surface_state); + } } }