From 73835874a82f741e10cbc8da9128a4f5cd46e347 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sat, 13 Jan 2024 21:06:38 -0800 Subject: [PATCH] intel/disasm: Remove duplicate variable reg_file Fix defects reported by Coverity Scan. Evaluation order violation (EVALUATION_ORDER) write_write_typo: In reg_file = reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst), reg_file is written twice with the same value. Fixes: 1c92dad5cb7 ("intel/disasm: Disassembly support for DPAS") Signed-off-by: Vinson Lee Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/compiler/brw_disasm.c | 12 ++++-------- 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c index c56d4e554ca..7c482eae0c6 100644 --- a/src/intel/compiler/brw_disasm.c +++ b/src/intel/compiler/brw_disasm.c @@ -1061,8 +1061,7 @@ static int dest_dpas_3src(FILE *file, const struct intel_device_info *devinfo, const brw_inst *inst) { - uint32_t reg_file = - reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst); + uint32_t reg_file = brw_inst_dpas_3src_dst_reg_file(devinfo, inst); if (reg(file, reg_file, brw_inst_dpas_3src_dst_reg_nr(devinfo, inst)) == -1) return 0; @@ -1557,8 +1556,7 @@ static int src0_dpas_3src(FILE *file, const struct intel_device_info *devinfo, const brw_inst *inst) { - uint32_t reg_file = - reg_file = brw_inst_dpas_3src_src0_reg_file(devinfo, inst); + uint32_t reg_file = brw_inst_dpas_3src_src0_reg_file(devinfo, inst); if (reg(file, reg_file, brw_inst_dpas_3src_src0_reg_nr(devinfo, inst)) == -1) return 0; @@ -1579,8 +1577,7 @@ static int src1_dpas_3src(FILE *file, const struct intel_device_info *devinfo, const brw_inst *inst) { - uint32_t reg_file = - reg_file = brw_inst_dpas_3src_src1_reg_file(devinfo, inst); + uint32_t reg_file = brw_inst_dpas_3src_src1_reg_file(devinfo, inst); if (reg(file, reg_file, brw_inst_dpas_3src_src1_reg_nr(devinfo, inst)) == -1) return 0; @@ -1601,8 +1598,7 @@ static int src2_dpas_3src(FILE *file, const struct intel_device_info *devinfo, const brw_inst *inst) { - uint32_t reg_file = - reg_file = brw_inst_dpas_3src_src2_reg_file(devinfo, inst); + uint32_t reg_file = brw_inst_dpas_3src_src2_reg_file(devinfo, inst); if (reg(file, reg_file, brw_inst_dpas_3src_src2_reg_nr(devinfo, inst)) == -1) return 0;