From 7348a083ed1f8f06b497a9c3d96565453229e4cd Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Mon, 29 Mar 2021 15:51:08 -0400 Subject: [PATCH] zink: skip hash updates for descriptor types which aren't used this is pointless and hurts drawoverhead perf Reviewed-by: Hoe Hao Cheng Acked-by: Dave Airlie Part-of: --- src/gallium/drivers/zink/zink_descriptors.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/zink/zink_descriptors.c b/src/gallium/drivers/zink/zink_descriptors.c index 25aa3671469..814c2767894 100644 --- a/src/gallium/drivers/zink/zink_descriptors.c +++ b/src/gallium/drivers/zink/zink_descriptors.c @@ -1577,7 +1577,7 @@ zink_context_update_descriptor_states(struct zink_context *ctx, struct zink_prog ctx->dd->last_push_usage[pg->is_compute] = pg->dd->push_usage; } for (unsigned i = 0; i < ZINK_DESCRIPTOR_TYPES; i++) { - if (!ctx->dd->descriptor_states[pg->is_compute].valid[i]) + if (pdd_cached(pg)->pool[i] && !ctx->dd->descriptor_states[pg->is_compute].valid[i]) update_descriptor_state(ctx, i, pg->is_compute); } }