From 716e0e15681d8a704c44cf9bb9ff51ca32d6e45f Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Tue, 18 Jun 2024 11:08:44 +0200 Subject: [PATCH] panvk: Add missing null check in DestroyCommandPool Fix a crash when a null handle is passed. (dEQP-VK.api.null_handle.destroy_command_pool) Signed-off-by: Mary Guillemard Fixes: afbac1af773 ("panvk: Move the VkCommandPool logic to panvk_cmd_pool.{c,h}") Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/panvk_cmd_pool.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/panfrost/vulkan/panvk_cmd_pool.c b/src/panfrost/vulkan/panvk_cmd_pool.c index 5fbd37c86f4..ecbfc9e00cc 100644 --- a/src/panfrost/vulkan/panvk_cmd_pool.c +++ b/src/panfrost/vulkan/panvk_cmd_pool.c @@ -51,6 +51,9 @@ panvk_DestroyCommandPool(VkDevice _device, VkCommandPool commandPool, VK_FROM_HANDLE(panvk_device, device, _device); VK_FROM_HANDLE(panvk_cmd_pool, pool, commandPool); + if (!pool) + return; + vk_command_pool_finish(&pool->vk); panvk_bo_pool_cleanup(&pool->desc_bo_pool);