From 70945dd36293329568297d8ac9bc72c91cbca3f5 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Tue, 22 Sep 2020 17:51:06 -0700 Subject: [PATCH] aco: Initialize mad_info member literal_idx. Fix defect reported by Coverity Scan. Uninitialized scalar field (UNINIT_CTOR) uninit_member: Non-static class member literal_idx is not initialized in this constructor nor in any functions that it calls. Signed-off-by: Vinson Lee Reviewed-by: Tony Wasserka Reviewed-by: Rhys Perry Part-of: --- src/amd/compiler/aco_optimizer.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp index ea60ad10dba..a2640bd7220 100644 --- a/src/amd/compiler/aco_optimizer.cpp +++ b/src/amd/compiler/aco_optimizer.cpp @@ -77,7 +77,7 @@ struct mad_info { bool check_literal; mad_info(aco_ptr instr, uint32_t id) - : add_instr(std::move(instr)), mul_temp_id(id), check_literal(false) {} + : add_instr(std::move(instr)), mul_temp_id(id), literal_idx(0), check_literal(false) {} }; enum Label {