From 701ee4be913a98569a5ba2e0d4d4d8888c35249e Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Fri, 16 Feb 2024 11:54:32 -0500 Subject: [PATCH] zink: apply all storage memory masks to control barriers if no modes are specified fixes VUID-StandaloneSpirv-OpControlBarrier-04650 errors cc: mesa-stable Part-of: --- src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c index c270b3b0db8..9078171c79c 100644 --- a/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c +++ b/src/gallium/drivers/zink/nir_to_spirv/nir_to_spirv.c @@ -3208,6 +3208,11 @@ emit_barrier(struct ntv_context *ctx, nir_intrinsic_instr *intr) if (modes & (nir_var_shader_out | nir_var_mem_task_payload)) semantics |= SpvMemorySemanticsOutputMemoryMask; + if (!modes) + semantics = SpvMemorySemanticsWorkgroupMemoryMask | + SpvMemorySemanticsUniformMemoryMask | + SpvMemorySemanticsImageMemoryMask | + SpvMemorySemanticsCrossWorkgroupMemoryMask; semantics |= SpvMemorySemanticsAcquireReleaseMask; }