From 70066fb036bce2b9070587f101f56e67e3088bbc Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 31 Mar 2021 15:45:11 +0200 Subject: [PATCH] zink: do not request scoped memory barriers While barriers in Vulkan are scoped, we do not handle nir_intrinsic_scoped_barrier, so we do not support them from NIR. The reason why this hasn't been a problem seems to be that VTN is the only place that respects them, so we haven't seen them yet. But if the GLSL compiler starts respecting the setting, things will start blowing up. There's WIP patches for this in !3339 already. Reviewed-By: Mike Blumenkrantz Part-of: --- src/gallium/drivers/zink/zink_compiler.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gallium/drivers/zink/zink_compiler.c b/src/gallium/drivers/zink/zink_compiler.c index 36887a24c99..780e2f5294e 100644 --- a/src/gallium/drivers/zink/zink_compiler.c +++ b/src/gallium/drivers/zink/zink_compiler.c @@ -329,7 +329,6 @@ zink_screen_init_compiler(struct zink_screen *screen) .lower_pack_64_2x32_split = true, .lower_unpack_64_2x32_split = true, .lower_vector_cmp = true, - .use_scoped_barrier = true, .lower_int64_options = 0, .lower_doubles_options = ~nir_lower_fp64_full_software, .has_fsub = true,