From 6a5863df828d284c94835c9a231e896b129cb0b2 Mon Sep 17 00:00:00 2001 From: Dylan Baker Date: Tue, 1 Nov 2022 12:55:12 -0700 Subject: [PATCH] util/glsl2spriv: make --vn required I'm not 100% sure whether it's right to make --vn required, or to avoid the static conversion, but this seems correct. Mypy (type checking coming soon) points out that if --vn is None then the convert_to_static_variable function will fail. Our one use of this sets --vn, so there is no change there. Making --vn required ensures that it will never be None, avoiding the problem. Reviewed-by: Luis Felipe Strano Moraes Part-of: --- src/util/glsl2spirv.py | 1 + 1 file changed, 1 insertion(+) diff --git a/src/util/glsl2spirv.py b/src/util/glsl2spirv.py index fd5fa9c6208..1faec6f919b 100644 --- a/src/util/glsl2spirv.py +++ b/src/util/glsl2spirv.py @@ -53,6 +53,7 @@ def get_args(): parser.add_argument("--vn", dest="vn", + required=True, help="Variable name. Creates a C header file that contains a uint32_t array.") parser.add_argument("--stage",