From 69b178ac9099dff3bb84f195b5167bc41493e6f2 Mon Sep 17 00:00:00 2001 From: Emma Anholt Date: Wed, 22 Feb 2023 12:03:34 -0800 Subject: [PATCH] glsl/opt_algebraic: Drop add/sub with 0 optimizations. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Looks like minor instruction selection noise in freedreno shader-db: total instructions in shared programs: 11013100 -> 11013096 (<.01%) instructions in affected programs: 2714 -> 2710 (-0.15%) helped: 8 HURT: 6 Acked-by: Timothy Arceri Reviewed-by: Marek Olšák Part-of: --- src/compiler/glsl/opt_algebraic.cpp | 12 ------------ 1 file changed, 12 deletions(-) diff --git a/src/compiler/glsl/opt_algebraic.cpp b/src/compiler/glsl/opt_algebraic.cpp index e6c127d5a3c..2d8f5cf3d10 100644 --- a/src/compiler/glsl/opt_algebraic.cpp +++ b/src/compiler/glsl/opt_algebraic.cpp @@ -322,11 +322,6 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir) #undef HANDLE_PACK_UNPACK_INVERSE case ir_binop_add: - if (is_vec_zero(op_const[0])) - return ir->operands[1]; - if (is_vec_zero(op_const[1])) - return ir->operands[0]; - /* Replace (x + (-x)) with constant 0 */ for (int i = 0; i < 2; i++) { if (op_expr[i]) { @@ -402,13 +397,6 @@ ir_algebraic_visitor::handle_expression(ir_expression *ir) break; - case ir_binop_sub: - if (is_vec_zero(op_const[0])) - return neg(ir->operands[1]); - if (is_vec_zero(op_const[1])) - return ir->operands[0]; - break; - case ir_binop_mul: if (is_vec_one(op_const[0])) return ir->operands[1];