diff --git a/src/amd/vulkan/meson.build b/src/amd/vulkan/meson.build index 6d2927cb455..a3870ad7007 100644 --- a/src/amd/vulkan/meson.build +++ b/src/amd/vulkan/meson.build @@ -78,6 +78,7 @@ libradv_files = files( 'nir/radv_nir_lower_primitive_shading_rate.c', 'nir/radv_nir_lower_ray_queries.c', 'nir/radv_nir_lower_view_index.c', + 'nir/radv_nir_lower_viewport_to_zero.c', 'nir/radv_nir_lower_vs_inputs.c', 'winsys/null/radv_null_bo.c', 'winsys/null/radv_null_bo.h', diff --git a/src/amd/vulkan/nir/radv_nir.h b/src/amd/vulkan/nir/radv_nir.h index e4b63e192ce..917b712cf47 100644 --- a/src/amd/vulkan/nir/radv_nir.h +++ b/src/amd/vulkan/nir/radv_nir.h @@ -66,6 +66,8 @@ bool radv_nir_lower_intrinsics_early(nir_shader *nir, const struct radv_pipeline bool radv_nir_lower_view_index(nir_shader *nir, bool per_primitive); +bool radv_nir_lower_viewport_to_zero(nir_shader *nir); + #ifdef __cplusplus } #endif diff --git a/src/amd/vulkan/nir/radv_nir_lower_viewport_to_zero.c b/src/amd/vulkan/nir/radv_nir_lower_viewport_to_zero.c new file mode 100644 index 00000000000..4cc1ed3f8de --- /dev/null +++ b/src/amd/vulkan/nir/radv_nir_lower_viewport_to_zero.c @@ -0,0 +1,69 @@ +/* + * Copyright © 2016 Red Hat. + * Copyright © 2016 Bas Nieuwenhuizen + * Copyright © 2023 Valve Corporation + * + * Permission is hereby granted, free of charge, to any person obtaining a + * copy of this software and associated documentation files (the "Software"), + * to deal in the Software without restriction, including without limitation + * the rights to use, copy, modify, merge, publish, distribute, sublicense, + * and/or sell copies of the Software, and to permit persons to whom the + * Software is furnished to do so, subject to the following conditions: + * + * The above copyright notice and this permission notice (including the next + * paragraph) shall be included in all copies or substantial portions of the + * Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, + * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL + * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER + * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING + * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS + * IN THE SOFTWARE. + */ + +#include "nir.h" +#include "nir_builder.h" +#include "radv_nir.h" + +bool +radv_nir_lower_viewport_to_zero(nir_shader *nir) +{ + nir_function_impl *impl = nir_shader_get_entrypoint(nir); + bool progress = false; + + nir_builder b; + nir_builder_init(&b, impl); + + /* There should be only one deref load for VIEWPORT after lower_io_to_temporaries. */ + nir_foreach_block (block, impl) { + nir_foreach_instr (instr, block) { + if (instr->type != nir_instr_type_intrinsic) + continue; + + nir_intrinsic_instr *intr = nir_instr_as_intrinsic(instr); + if (intr->intrinsic != nir_intrinsic_load_deref) + continue; + + nir_variable *var = nir_intrinsic_get_var(intr, 0); + if (var->data.mode != nir_var_shader_in || var->data.location != VARYING_SLOT_VIEWPORT) + continue; + + b.cursor = nir_before_instr(instr); + + nir_ssa_def_rewrite_uses(&intr->dest.ssa, nir_imm_zero(&b, 1, 32)); + progress = true; + break; + } + if (progress) + break; + } + + if (progress) + nir_metadata_preserve(impl, nir_metadata_block_index | nir_metadata_dominance); + else + nir_metadata_preserve(impl, nir_metadata_all); + + return progress; +} diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c index e3a35bd07c2..5a5e6993ffd 100644 --- a/src/amd/vulkan/radv_pipeline.c +++ b/src/amd/vulkan/radv_pipeline.c @@ -1455,48 +1455,6 @@ get_vs_output_info(const struct radv_graphics_pipeline *pipeline) return &radv_get_last_vgt_shader(pipeline)->info.outinfo; } -static bool -radv_lower_viewport_to_zero(nir_shader *nir) -{ - nir_function_impl *impl = nir_shader_get_entrypoint(nir); - bool progress = false; - - nir_builder b; - nir_builder_init(&b, impl); - - /* There should be only one deref load for VIEWPORT after lower_io_to_temporaries. */ - nir_foreach_block(block, impl) { - nir_foreach_instr(instr, block) { - if (instr->type != nir_instr_type_intrinsic) - continue; - - nir_intrinsic_instr *intr = nir_instr_as_intrinsic(instr); - if (intr->intrinsic != nir_intrinsic_load_deref) - continue; - - nir_variable *var = nir_intrinsic_get_var(intr, 0); - if (var->data.mode != nir_var_shader_in || - var->data.location != VARYING_SLOT_VIEWPORT) - continue; - - b.cursor = nir_before_instr(instr); - - nir_ssa_def_rewrite_uses(&intr->dest.ssa, nir_imm_zero(&b, 1, 32)); - progress = true; - break; - } - if (progress) - break; - } - - if (progress) - nir_metadata_preserve(impl, nir_metadata_block_index | nir_metadata_dominance); - else - nir_metadata_preserve(impl, nir_metadata_all); - - return progress; -} - static nir_variable * find_layer_out_var(nir_shader *nir) { @@ -1759,7 +1717,7 @@ radv_pipeline_link_shaders(const struct radv_device *device, /* Lower the viewport index to zero when the last vertex stage doesn't export it. */ if ((consumer->info.inputs_read & VARYING_BIT_VIEWPORT) && !(producer->info.outputs_written & VARYING_BIT_VIEWPORT)) { - NIR_PASS(_, consumer, radv_lower_viewport_to_zero); + NIR_PASS(_, consumer, radv_nir_lower_viewport_to_zero); } /* Lower the view index to map on the layer. */