From 670fd8123be4c6142239439d1273b3a4d8a58cb1 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Sun, 17 Oct 2021 19:55:54 -0700 Subject: [PATCH] radv: Fix memory leak on error path. Fix defect reported by Coverity Scan. Resource leak (RESOURCE_LEAK) leaked_storage: Variable prolog going out of scope leaks the storage it points to Fixes: 80841196b2d ("radv: implement dynamic vertex input state using vertex shader prologs") Suggested-by: Rhys Perry Signed-off-by: Vinson Lee Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_cmd_buffer.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index 7a1c90bb1cf..3c7882a8297 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -2839,6 +2839,7 @@ lookup_vs_prolog(struct radv_cmd_buffer *cmd_buffer, struct radv_shader_variant prolog = radv_create_vs_prolog(device, &key); uint32_t *key2 = malloc(key_size * 4); if (!prolog || !key2) { + radv_prolog_destroy(device, prolog); free(key2); u_rwlock_wrunlock(&device->vs_prologs_lock); return NULL;