From 6628f24e4db003afe948ed17d8ab90477a793713 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 17 Jun 2024 17:56:00 -0400 Subject: [PATCH] agx: fix insidious ballot optimizer bug see next test. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/asahi/compiler/agx_optimizer.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/asahi/compiler/agx_optimizer.c b/src/asahi/compiler/agx_optimizer.c index 257ccc258a8..fe9124bea79 100644 --- a/src/asahi/compiler/agx_optimizer.c +++ b/src/asahi/compiler/agx_optimizer.c @@ -376,6 +376,9 @@ agx_optimizer_cmpsel(agx_instr **defs, agx_instr *I) static void agx_optimizer_ballot(agx_context *ctx, agx_instr **defs, agx_instr *I) { + if (I->src[0].type != AGX_INDEX_NORMAL) + return; + agx_instr *def = defs[I->src[0].value]; if (!def || (def->op != AGX_OPCODE_ICMP && def->op != AGX_OPCODE_FCMP)) return;