From 65961848b11b5ad67be28b1709c30f144ecff9cf Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Fri, 24 Jun 2022 11:53:16 -0400 Subject: [PATCH] pan/bi: Remove bogus assert for pack_32_2x16 The following IR is valid NIR: vec1 16 ssa_0 = ... vec1 32 ssa_1 = pack_32_2x16 ssa_0.xx In this case, pack_32_2x16 takes in a two component vector, but the source itself ssa_0 has only a single component. This is fine due to the shuffle, but will fail the assert. Remove the assert and all is well. Fixes test_relational.shuffle_copy. Signed-off-by: Alyssa Rosenzweig Part-of: --- src/panfrost/bifrost/bifrost_compile.c | 1 - 1 file changed, 1 deletion(-) diff --git a/src/panfrost/bifrost/bifrost_compile.c b/src/panfrost/bifrost/bifrost_compile.c index b83cc413a82..4ed0806518f 100644 --- a/src/panfrost/bifrost/bifrost_compile.c +++ b/src/panfrost/bifrost/bifrost_compile.c @@ -2388,7 +2388,6 @@ bi_emit_alu(bi_builder *b, nir_alu_instr *instr) } case nir_op_pack_32_2x16: { - assert(nir_src_num_components(instr->src[0].src) == 2); assert(comps == 1); bi_index idx = bi_src_index(&instr->src[0].src);