From 60cf1ede4fa78da66bc7729a3e2bf0a6a980d337 Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Thu, 15 Feb 2024 15:12:46 -0800 Subject: [PATCH] iris: Remove no-ops from storage image lowering The atomics lowering only applies to Gfx <= 7.5. The get_size lowering only applies to Gfx <= 8. Note: the lower_store still applies for Gfx9+, to perform color conversion. Reviewed-by: Kenneth Graunke Part-of: --- src/gallium/drivers/iris/iris_program.c | 13 ++++++++----- 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/src/gallium/drivers/iris/iris_program.c b/src/gallium/drivers/iris/iris_program.c index 837315def34..d8bb664456d 100644 --- a/src/gallium/drivers/iris/iris_program.c +++ b/src/gallium/drivers/iris/iris_program.c @@ -2951,11 +2951,14 @@ iris_finalize_nir(struct pipe_screen *_screen, void *nirptr) NIR_PASS_V(nir, brw_nir_lower_storage_image, &(struct brw_nir_lower_storage_image_opts) { - .devinfo = devinfo, - .lower_loads = true, - .lower_stores = true, - .lower_atomics = true, - .lower_get_size = true, + .devinfo = devinfo, + .lower_loads = true, + .lower_stores = true, + + /* Iris uploads image params used by + * get_size lowering only in Gfx8. + */ + .lower_get_size = devinfo->ver == 8, }); NIR_PASS_V(nir, iris_lower_storage_image_derefs);