From 5e813a15f8428d9207ae59e6f2aae5f4d743682f Mon Sep 17 00:00:00 2001 From: Mike Blumenkrantz Date: Wed, 14 Feb 2024 16:18:45 -0500 Subject: [PATCH] zink: update vvl expectations Reviewed-by: Dave Airlie Part-of: --- .../zink/ci/zink-lvp-validation-settings.txt | 82 +------------------ 1 file changed, 1 insertion(+), 81 deletions(-) diff --git a/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt b/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt index c424cfda6a0..c16c99c8341 100644 --- a/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt +++ b/src/gallium/drivers/zink/ci/zink-lvp-validation-settings.txt @@ -1,6 +1,6 @@ # Please include a comment with the log message and a testcase triggering each # VUID at the bottom of the file. -khronos_validation.message_id_filter = VUID-VkPhysicalDeviceProperties2-pNext-pNext,VUID-VkDeviceCreateInfo-pNext-pNext,VUID-VkGraphicsPipelineCreateInfo-Geometry-07725,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-vkCmdCopyImage-srcImage-07743,VUID-RuntimeSpirv-Location-06272,VUID-vkCmdDrawMultiEXT-None-02699,VUID-VkShaderModuleCreateInfo-pCode-01091,VUID-VkShaderModuleCreateInfo-pCode-08740,VUID-RuntimeSpirv-OpEntryPoint-08743,VUID-vkCmdDrawMultiEXT-rasterizationSamples-07471,VUID-vkCmdDrawMultiIndexedEXT-rasterizationSamples-07471 +khronos_validation.message_id_filter = VUID-VkPhysicalDeviceProperties2-pNext-pNext,VUID-VkDeviceCreateInfo-pNext-pNext,VUID-RuntimeSpirv-Location-06272,VUID-vkCmdDrawMultiEXT-None-02699,VUID-RuntimeSpirv-OpEntryPoint-08743 khronos_validation.report_flags = error khronos_validation.debug_action = VK_DBG_LAYER_ACTION_LOG_MSG,VK_DBG_LAYER_ACTION_BREAK VK_LAYER_ENABLES=VK_VALIDATION_FEATURE_ENABLE_DEBUG_PRINTF_EXT @@ -13,47 +13,6 @@ khronos_validation.log_filename = stdout # never error due to unrecognized extensions -# dEQP-GLES31.functional.geometry_shading.emit.points_emit_0_end_1: -# -# [ VUID-VkGraphicsPipelineCreateInfo-Geometry-07725 ] Object 0: handle = -# 0x2e2941000000001f, type = VK_OBJECT_TYPE_SHADER_MODULE; | MessageID = -# 0x64e29d24 | vkCreateGraphicsPipelines(): -# shaderTessellationAndGeometryPointSize is enabled, but PointSize is not -# written in the Geometry shader. The Vulkan spec states: If the pipeline -# is being created with a Geometry {ExecutionModel}, uses the -# OutputPoints {ExecutionMode}, and -# shaderTessellationAndGeometryPointSize is enabled, a PointSize -# decorated variable must be written to -# (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkGraphicsPipelineCreateInfo-Geometry-07725) - -# KHR-GL46.compute_shader.resources-max: -# -# [ VUID-VkShaderModuleCreateInfo-pCode-01091 ] Object 0: handle = -# 0x55b4bf3a48d0, type = VK_OBJECT_TYPE_DEVICE; | MessageID = 0xa7bb8db6 -# | vkCreateShaderModule(): The SPIR-V Capability -# (StorageImageArrayDynamicIndexing) was declared, but none of the -# requirements were met to use it. The Vulkan spec states: If pCode -# declares any of the capabilities listed in the SPIR-V Environment -# appendix, one of the corresponding requirements must be satisfied -# (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-01091) -# -# lvp doesn't support the feature and we don't lower it. Hopefully lvp gains it with -# https://gitlab.freedesktop.org/mesa/mesa/-/issues/6972 - -# KHR-GL46.copy_image.invalid_target: -# -# [ VUID-vkCmdCopyImage-srcImage-07743 ] Object 0: handle = -# 0x557060e9ffd0, type = VK_OBJECT_TYPE_COMMAND_BUFFER; | MessageID = -# 0xa4e981d8 | vkCmdCopyImage: pRegion[0] srcImage (VK_IMAGE_TYPE_2D) -# must be equal to dstImage (VK_IMAGE_TYPE_1D) or else one must be 2D and -# the other 3D The Vulkan spec states: If srcImage and dstImage have a -# different VkImageType, one must be VK_IMAGE_TYPE_3D and the other must -# be VK_IMAGE_TYPE_2D -# (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkCmdCopyImage-srcImage-07743) -# -# Recent VU regression: -# https://gitlab.khronos.org/vulkan/vulkan/-/issues/3357 - # KHR-GL46.shader_image_load_store.basic-allTargets-atomic: # [ VUID-vkCmdDrawMultiEXT-viewType-07752 ] Object 0: handle = # 0x5581c500000000d5, type = VK_OBJECT_TYPE_DESCRIPTOR_SET; | MessageID = @@ -78,27 +37,6 @@ khronos_validation.log_filename = stdout # Input and Output Locations # (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-RuntimeSpirv-Location-06272) -# KHR-GL46.shading_language_420pack.binding_image_array -# -# VUID-VkShaderModuleCreateInfo-pCode-01091(ERROR / SPEC): msgNum: -1480880714 - -# Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-01091 ] -# vkCreateShaderModule(): The SPIR-V Capability (StorageImageArrayDynamicIndexing) was declared, -# but none of the requirements were met to use it. -# The Vulkan spec states: If pCode declares any of the capabilities listed in the -# SPIR-V Environment appendix, one of the corresponding requirements must be satisfied -# (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-01091) -# -# VUID-VkShaderModuleCreateInfo-pCode-08740(ERROR / SPEC): msgNum: 115483881 - -# Validation Error: [ VUID-VkShaderModuleCreateInfo-pCode-08740 ] -# vkCreateShaderModule(): The SPIR-V Capability (StorageImageArrayDynamicIndexing) -# was declared, but none of the requirements were met to use it. -# The Vulkan spec states: If pname:codeType is ename:VK_SHADER_CODE_TYPE_SPIRV_EXT, -# and pCode declares any of the capabilities listed in the SPIR-V Environment appendix, -# one of the corresponding requirements must be satisfied -# (https://www.khronos.org/registry/vulkan/specs/1.3-khr-extensions/html/vkspec.html#VUID-VkShaderModuleCreateInfo-pCode-08740) -# -# needs lavapipe features - # dEQP-GLES31.functional.separate_shader.random.69 # # UNASSIGNED-CoreValidation-Shader-MissingOutput(ERROR / SPEC): msgNum: 1086655814 - @@ -117,21 +55,3 @@ khronos_validation.log_filename = stdout # (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-RuntimeSpirv-OpEntryPoint-08743) # # VVL bug https://github.com/KhronosGroup/Vulkan-ValidationLayers/issues/5735 - - -# dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_4 -# -# VUID-vkCmdDrawMultiEXT-rasterizationSamples-07471(ERROR / SPEC): msgNum: 1182038117 - -# Validation Error: [ VUID-vkCmdDrawMultiEXT-rasterizationSamples-07471 ] -# Object 0: handle = 0x868e960, type = VK_OBJECT_TYPE_COMMAND_BUFFER; Object 1: handle = 0x74ea280000000054, -# type = VK_OBJECT_TYPE_PIPELINE; | MessageID = 0x46747865 | -# vkCmdDrawMultiEXT(): VkPhysicalDeviceFeatures::variableMultisampleRate is VK_FALSE and the -# rasterizationSamples set with vkCmdSetRasterizationSamplesEXT() were VK_SAMPLE_COUNT_1_BIT -# but a previous draw used rasterization samples 4.. -# The Vulkan spec states: If the bound graphics pipeline state was created with the -# VK_DYNAMIC_STATE_RASTERIZATION_SAMPLES_EXT state enabled, and the current subpass does -# not use any color and/or depth/stencil attachments, then the rasterizationSamples -# in the last call to vkCmdSetRasterizationSamplesEXT must follow the rules for a zero-attachment subpass -# (https://www.khronos.org/registry/vulkan/specs/1.3-extensions/html/vkspec.html#VUID-vkCmdDrawMultiEXT-rasterizationSamples-07471) -# -# VVL bug dEQP-GLES31.functional.shaders.sample_variables.sample_pos.correctness.multisample_texture_4