From 5e07edd4f6c0690f5c9cc05d9efb6e1520c9a19c Mon Sep 17 00:00:00 2001 From: Boris Brezillon Date: Wed, 3 Apr 2024 11:25:45 +0200 Subject: [PATCH] panvk: Don't advertize vertex_buffer cap on sRGB formats Signed-off-by: Boris Brezillon Reviewed-by: Mary Guillemard Part-of: --- src/panfrost/vulkan/panvk_physical_device.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 1dbc2797ae4..445eecd8d55 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -828,7 +828,10 @@ get_format_properties(struct panvk_physical_device *physical_device, buffer |= VK_FORMAT_FEATURE_TRANSFER_SRC_BIT | VK_FORMAT_FEATURE_TRANSFER_DST_BIT; - if (fmt.bind & PAN_BIND_VERTEX_BUFFER) + /* Reject sRGB formats (see + * https://github.com/KhronosGroup/Vulkan-Docs/issues/2214). + */ + if ((fmt.bind & PAN_BIND_VERTEX_BUFFER) && !util_format_is_srgb(pfmt)) buffer |= VK_FORMAT_FEATURE_VERTEX_BUFFER_BIT; if (fmt.bind & PAN_BIND_SAMPLER_VIEW) {