From 5d55ca9c300a6e240cf9216bba203321b7b44c90 Mon Sep 17 00:00:00 2001 From: Lionel Landwerlin Date: Thu, 26 Nov 2020 16:37:01 +0200 Subject: [PATCH] anv: fix descriptor pool leak in VMA object Quoting the spec : "When a pool is destroyed, all descriptor sets allocated from the pool are implicitly freed and become invalid. Descriptor sets allocated from a given pool do not need to be freed before destroying that descriptor pool." This implies we might leak nodes allocated in the vma object. Signed-off-by: Lionel Landwerlin Fixes: 0a6d2593b8b63d ("anv: Allocate descriptor buffers from the BO cache") Reviewed-by: Jason Ekstrand Part-of: --- src/intel/vulkan/anv_descriptor_set.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_descriptor_set.c b/src/intel/vulkan/anv_descriptor_set.c index a0a45405d6b..e3895a77234 100644 --- a/src/intel/vulkan/anv_descriptor_set.c +++ b/src/intel/vulkan/anv_descriptor_set.c @@ -909,8 +909,10 @@ void anv_DestroyDescriptorPool( anv_descriptor_set_layout_unref(device, set->layout); } - if (pool->bo) + if (pool->bo) { + util_vma_heap_finish(&pool->bo_heap); anv_device_release_bo(device, pool->bo); + } anv_state_stream_finish(&pool->surface_state_stream); vk_object_base_finish(&pool->base);