From 5ccee0fe83e46a7dd1988e1962ae8d5e21e86873 Mon Sep 17 00:00:00 2001 From: Georg Lehmann Date: Wed, 4 Sep 2024 16:31:51 +0200 Subject: [PATCH] radv: remove nir_opt_reuse_constants call MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit aco now rematerializes constants per block, so this nir pass no longer does anything meaningful besides adding noise: Foz-DB Navi31: Totals from 4674 (5.89% of 79395) affected shaders: Instrs: 11497431 -> 11497335 (-0.00%); split: -0.02%, +0.02% CodeSize: 60720620 -> 60725904 (+0.01%); split: -0.02%, +0.03% VGPRs: 294440 -> 294428 (-0.00%) SpillSGPRs: 3486 -> 3488 (+0.06%); split: -0.06%, +0.11% Latency: 109298610 -> 109319617 (+0.02%); split: -0.02%, +0.04% InvThroughput: 18606377 -> 18640872 (+0.19%); split: -0.01%, +0.19% VClause: 232602 -> 232622 (+0.01%); split: -0.00%, +0.01% SClause: 299675 -> 299746 (+0.02%); split: -0.01%, +0.04% Copies: 840683 -> 840105 (-0.07%); split: -0.14%, +0.07% Branches: 304581 -> 304646 (+0.02%); split: -0.00%, +0.03% PreSGPRs: 233651 -> 233611 (-0.02%); split: -0.02%, +0.00% VALU: 6624760 -> 6625051 (+0.00%); split: -0.00%, +0.01% SALU: 1236841 -> 1236103 (-0.06%); split: -0.12%, +0.06% VOPD: 2993 -> 2970 (-0.77%); split: +0.17%, -0.94% Reviewed-by: Daniel Schürmann Part-of: --- src/amd/vulkan/radv_shader.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/src/amd/vulkan/radv_shader.c b/src/amd/vulkan/radv_shader.c index 74da67d96ba..7404849a45f 100644 --- a/src/amd/vulkan/radv_shader.c +++ b/src/amd/vulkan/radv_shader.c @@ -374,9 +374,6 @@ radv_shader_spirv_to_nir(struct radv_device *device, const struct radv_shader_st radv_device_associate_nir(device, nir); - /* TODO: This can be removed once GCM (which is more general) is used. */ - NIR_PASS(_, nir, nir_opt_reuse_constants); - const struct nir_lower_sysvals_to_varyings_options sysvals_to_varyings = { .point_coord = true, };