From 565b388acf9843126f8a7e05ed42c1b17e6eed81 Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Mon, 5 Sep 2022 13:18:39 +0200 Subject: [PATCH] v3dv: fix swap_rb and channel_reverse flags in image views MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We were computing these from the final swizzle resulting from combining the format swizzle and the view swizzle, but here we want to use the format swizzle alone, which is the one we use to define these properties in the format table. Fixes CTS test fails with EXT_border_color_swizzle. Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/vulkan/v3dv_image.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/broadcom/vulkan/v3dv_image.c b/src/broadcom/vulkan/v3dv_image.c index 1504fc18369..ebf2432b132 100644 --- a/src/broadcom/vulkan/v3dv_image.c +++ b/src/broadcom/vulkan/v3dv_image.c @@ -571,8 +571,8 @@ create_image_view(struct v3dv_device *device, util_format_compose_swizzles(format_swizzle, image_view_swizzle, iview->swizzle); - iview->swap_rb = v3dv_format_swizzle_needs_rb_swap(iview->swizzle); - iview->channel_reverse = v3dv_format_swizzle_needs_reverse(iview->swizzle); + iview->swap_rb = v3dv_format_swizzle_needs_rb_swap(format_swizzle); + iview->channel_reverse = v3dv_format_swizzle_needs_reverse(format_swizzle); v3dv_X(device, pack_texture_shader_state)(device, iview);