From 55e99728e03cc8a290db4d1b97d7d512361b362c Mon Sep 17 00:00:00 2001 From: Danylo Piliaiev Date: Tue, 27 Feb 2024 18:54:08 +0100 Subject: [PATCH] tu: Do not emit zero-sized fs params The comparison change accidentally slipped in. Fixes a crash in: dEQP-VK.subgroups.size_control.framebuffer.fragment_allow_varying_subgroup_size Fixes: 76e417ca593866080731da59c479a99542e3a529 ("turnip,ir3/a750: Implement consts loading via preamble") Signed-off-by: Danylo Piliaiev Part-of: --- src/freedreno/vulkan/tu_cmd_buffer.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/freedreno/vulkan/tu_cmd_buffer.cc b/src/freedreno/vulkan/tu_cmd_buffer.cc index 0386f7ee54a..271cc187e89 100644 --- a/src/freedreno/vulkan/tu_cmd_buffer.cc +++ b/src/freedreno/vulkan/tu_cmd_buffer.cc @@ -4701,7 +4701,7 @@ fs_params_offset(struct tu_cmd_buffer *cmd) &cmd->state.program.link[MESA_SHADER_FRAGMENT]; const struct ir3_const_state *const_state = &link->const_state; - if (const_state->num_driver_params < IR3_DP_FS_DYNAMIC) + if (const_state->num_driver_params <= IR3_DP_FS_DYNAMIC) return 0; if (const_state->offsets.driver_param + IR3_DP_FS_DYNAMIC / 4 >= link->constlen)