From 5515160b55cb17187e5cde401c67ae42e56b5fad Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Wed, 19 Nov 2025 10:36:10 -0500 Subject: [PATCH] nir/lower_wrmasks: drop support for I/O MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit nir_lower_wrmasks as-is is broken for semantic I/O, since semantic I/O is slot based and nir_lower_wrmasks is purely byte-based. No drivers use it as such, and no drivers should. Remove the support so people don't think it works. This came up in !38482. Signed-off-by: Alyssa Rosenzweig Reviewed-by: Kenneth Graunke Reviewed-by: Marek Olšák Part-of: --- src/compiler/nir/nir_lower_wrmasks.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/compiler/nir/nir_lower_wrmasks.c b/src/compiler/nir/nir_lower_wrmasks.c index 3db77b278df..78071d3fd76 100644 --- a/src/compiler/nir/nir_lower_wrmasks.c +++ b/src/compiler/nir/nir_lower_wrmasks.c @@ -62,9 +62,6 @@ static int value_src(nir_intrinsic_op intrinsic) { switch (intrinsic) { - case nir_intrinsic_store_output: - case nir_intrinsic_store_per_vertex_output: - case nir_intrinsic_store_per_view_output: case nir_intrinsic_store_ssbo: case nir_intrinsic_store_shared: case nir_intrinsic_store_global: @@ -79,13 +76,10 @@ static int offset_src(nir_intrinsic_op intrinsic) { switch (intrinsic) { - case nir_intrinsic_store_output: case nir_intrinsic_store_shared: case nir_intrinsic_store_global: case nir_intrinsic_store_scratch: return 1; - case nir_intrinsic_store_per_vertex_output: - case nir_intrinsic_store_per_view_output: case nir_intrinsic_store_ssbo: return 2; default: