From 504e511c4466743d89259488f467b91745087681 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 2 Jul 2025 12:34:33 +0200 Subject: [PATCH] panfrost: limit sample_shading to bifrost and later We haven't wired this up in the Midgard compiler, so we can't expose sample shading on Midgard GPUs. This all seems fixable, because the KILL instruction can update the coverage without the kill-flag (yeah, a bit confusing naming), but until someone puts in the time to wire up that, let's just disable the functionality to avoid crashes. Fixes: 6bba718027e ("panfrost: Advertise SAMPLE_SHADING") Reviewed-by: Eric R. Smith Reviewed-by: Mary Guillemard Part-of: --- src/gallium/drivers/panfrost/pan_screen.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c index 2b037fe9114..566f716c04b 100644 --- a/src/gallium/drivers/panfrost/pan_screen.c +++ b/src/gallium/drivers/panfrost/pan_screen.c @@ -639,7 +639,7 @@ panfrost_init_screen_caps(struct panfrost_screen *screen) caps->depth_clip_disable = true; caps->mixed_framebuffer_sizes = true; caps->frontend_noop = true; - caps->sample_shading = true; + caps->sample_shading = dev->arch >= 6; caps->fragment_shader_derivatives = true; caps->framebuffer_no_attachment = true; caps->quads_follow_provoking_vertex_convention = true;