From 4be89d7ad1a464f2c9bcc2bc7e457189622716c6 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Wed, 29 May 2024 14:52:28 +0200 Subject: [PATCH] panfrost: lower maxVertexInputStride to match vulkan runtime Since we now use the common vulkan runtime to handle pipeline state and this sets a limit for this at MESA_VK_MAX_VERTEX_BINDING_STRIDE we should do the same, or else we can run into an assert-fail in the runtime code. Basically the same as !29454, but for Panfrost. Fixes: 214761bdfe9 ("panvk: Fully transition to vk_vertex_binding_state") Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/panvk_physical_device.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 2fdbb9a410e..b3f130aa324 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -17,6 +17,7 @@ #include "vk_device.h" #include "vk_drm_syncobj.h" #include "vk_format.h" +#include "vk_limits.h" #include "vk_log.h" #include "vk_util.h" @@ -333,7 +334,7 @@ get_device_properties(const struct panvk_physical_device *device, /* MALI_ATTRIBUTE::offset is 32-bit. */ .maxVertexInputAttributeOffset = UINT32_MAX, /* MALI_ATTRIBUTE_BUFFER::stride is 32-bit. */ - .maxVertexInputBindingStride = UINT32_MAX, + .maxVertexInputBindingStride = MESA_VK_MAX_VERTEX_BINDING_STRIDE, /* 32 vec4 varyings. */ .maxVertexOutputComponents = 128, /* Tesselation shaders not supported. */