From 497005dc18c95a54290ee7a01de67b22bd2e1b8f Mon Sep 17 00:00:00 2001 From: Mary Guillemard Date: Wed, 10 Sep 2025 07:39:46 +0000 Subject: [PATCH] panvk: Enable SNORM rendering Blending should work properly those days. Signed-off-by: Mary Guillemard Reviewed-by: Erik Faye-Lund Reviewed-by: Boris Brezillon Part-of: --- src/panfrost/vulkan/panvk_physical_device.c | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 21e57b34b3c..36eeff82a94 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -557,16 +557,8 @@ get_image_plane_format_features(struct panvk_physical_device *physical_device, if (fmt.bind & PAN_BIND_RENDER_TARGET) { features |= VK_FORMAT_FEATURE_2_BLIT_DST_BIT; - - /* SNORM rendering isn't working yet (nir_lower_blend bugs), disable for - * now. - * - * XXX: Enable once fixed. - */ - if (!util_format_is_snorm(pfmt)) { - features |= VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BIT; - features |= VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT; - } + features |= VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BIT; + features |= VK_FORMAT_FEATURE_2_COLOR_ATTACHMENT_BLEND_BIT; } if (fmt.bind & PAN_BIND_STORAGE_IMAGE) {