From 484205b7ebfc937821b7196d779d9c51fcb7d612 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Tue, 20 Sep 2022 10:12:50 +0200 Subject: [PATCH] mesa/st: always use normalized coords for samplers Normalized samplers is the norm, and non-normalized samplers might cause some drivers and hardware to have to bend over backwards a bit. We're using TXF here anyway, so it doesn't really matter what we set this state to. So let's always use normalized samplers instead of always using non-normalized samplers. That makes things easier for everyone. Fixes: ed0e9862c56 ("st/mesa: implement PBO downloads for ReadPixels") Reviewed-By: Mike Blumenkrantz Part-of: --- src/mesa/state_tracker/st_cb_readpixels.c | 1 + 1 file changed, 1 insertion(+) diff --git a/src/mesa/state_tracker/st_cb_readpixels.c b/src/mesa/state_tracker/st_cb_readpixels.c index 6364d8f9444..5c96e1fb210 100644 --- a/src/mesa/state_tracker/st_cb_readpixels.c +++ b/src/mesa/state_tracker/st_cb_readpixels.c @@ -159,6 +159,7 @@ try_pbo_readpixels(struct st_context *st, struct gl_renderbuffer *rb, struct pipe_sampler_view templ; struct pipe_sampler_view *sampler_view; struct pipe_sampler_state sampler = {0}; + sampler.normalized_coords = true; const struct pipe_sampler_state *samplers[1] = {&sampler}; u_sampler_view_default_template(&templ, texture, src_format);