From 470f226ed846469eeadadeb9b3318b40045fb029 Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 21 Apr 2025 13:09:13 -0400 Subject: [PATCH] agx/nir_lower_gs: remove silly comment Signed-off-by: Alyssa Rosenzweig Reviewed-by: Mary Guillemard Part-of: --- src/asahi/lib/agx_nir_lower_gs.c | 13 ++++--------- 1 file changed, 4 insertions(+), 9 deletions(-) diff --git a/src/asahi/lib/agx_nir_lower_gs.c b/src/asahi/lib/agx_nir_lower_gs.c index c88e81ac278..f52c7831b45 100644 --- a/src/asahi/lib/agx_nir_lower_gs.c +++ b/src/asahi/lib/agx_nir_lower_gs.c @@ -1588,13 +1588,7 @@ lower_vs_before_gs(nir_builder *b, nir_intrinsic_instr *intr, void *data) nir_io_semantics sem = nir_intrinsic_io_semantics(intr); nir_def *location = nir_iadd_imm(b, intr->src[1].ssa, sem.location); - /* We inline the outputs_written because it's known at compile-time, even - * with shader objects. This lets us constant fold a bit of address math. - */ - nir_def *mask = nir_imm_int64(b, b->shader->info.outputs_written); - - nir_def *buffer; - nir_def *nr_verts; + nir_def *buffer, *nr_verts; if (b->shader->info.stage == MESA_SHADER_VERTEX) { buffer = nir_load_vs_output_buffer_agx(b); nr_verts = @@ -1610,8 +1604,9 @@ lower_vs_before_gs(nir_builder *b, nir_intrinsic_instr *intr, void *data) nir_def *linear_id = nir_iadd(b, nir_imul(b, load_instance_id(b), nr_verts), load_primitive_id(b)); - nir_def *addr = - libagx_vertex_output_address(b, buffer, mask, linear_id, location); + nir_def *addr = libagx_vertex_output_address( + b, buffer, nir_imm_int64(b, b->shader->info.outputs_written), linear_id, + location); assert(nir_src_bit_size(intr->src[0]) == 32); addr = nir_iadd_imm(b, addr, nir_intrinsic_component(intr) * 4);