From 450c8f159b7556f6f9898fc2859c5c5ff66ac977 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Timur=20Krist=C3=B3f?= Date: Wed, 3 Apr 2024 18:55:48 +0200 Subject: [PATCH] radv: Don't set driver locations for mesh shaders. MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit They were already unused, just don't set them. Signed-off-by: Timur Kristóf Reviewed-by: Samuel Pitoiset Part-of: --- src/amd/vulkan/radv_pipeline_graphics.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/src/amd/vulkan/radv_pipeline_graphics.c b/src/amd/vulkan/radv_pipeline_graphics.c index 62d737df4ed..8013949595d 100644 --- a/src/amd/vulkan/radv_pipeline_graphics.c +++ b/src/amd/vulkan/radv_pipeline_graphics.c @@ -1592,13 +1592,6 @@ radv_link_mesh(const struct radv_device *device, struct radv_shader_stage *mesh_ radv_link_shaders(device, mesh_stage, fs_stage, gfx_state); } - /* ac_nir_lower_ngg ignores driver locations for mesh shaders, but set them to all zero just to - * be on the safe side. - */ - nir_foreach_shader_out_variable (var, mesh_stage->nir) { - var->data.driver_location = 0; - } - /* Lower mesh shader draw ID to zero prevent app bugs from triggering undefined behaviour. */ if (mesh_stage->info.ms.has_task && BITSET_TEST(mesh_stage->nir->info.system_values_read, SYSTEM_VALUE_DRAW_ID)) radv_nir_lower_draw_id_to_zero(mesh_stage->nir);