From 44ed3e7341517f95441a2380e3474750c3d9426d Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Wed, 14 Jun 2023 23:17:36 -0700 Subject: [PATCH] microsoft/clc: Add unreachable() to fix 'may be unitialized' warning MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit In function ‘lower_load_kernel_input’, inlined from ‘clc_nir_lower_kernel_input_loads’ at ../src/microsoft/clc/clc_nir.c:205:28: ../src/microsoft/clc/clc_nir.c:169:7: warning: ‘base_type’ may be used uninitialized [-Wmaybe-uninitialized] 169 | glsl_vector_type(base_type, nir_dest_num_components(intr->dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ../src/microsoft/clc/clc_nir.c: In function ‘clc_nir_lower_kernel_input_loads’: ../src/microsoft/clc/clc_nir.c:151:24: note: ‘base_type’ was declared here 151 | enum glsl_base_type base_type; | ^~~~~~~~~ Part-of: --- src/microsoft/clc/clc_nir.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/microsoft/clc/clc_nir.c b/src/microsoft/clc/clc_nir.c index a5beedf035d..423a2e14a4b 100644 --- a/src/microsoft/clc/clc_nir.c +++ b/src/microsoft/clc/clc_nir.c @@ -157,12 +157,14 @@ lower_load_kernel_input(nir_builder *b, nir_intrinsic_instr *intr, case 32: base_type = GLSL_TYPE_UINT; break; - case 16: + case 16: base_type = GLSL_TYPE_UINT16; break; - case 8: + case 8: base_type = GLSL_TYPE_UINT8; break; + default: + unreachable("invalid bit size"); } const struct glsl_type *type =