From 43d00c2971ae641f41c789edc7d8413c877dacab Mon Sep 17 00:00:00 2001 From: Alyssa Rosenzweig Date: Mon, 20 Jun 2022 16:49:27 -0400 Subject: [PATCH] pan/va: Unit test barrier handling Add a unit test for the quirk discovered in the previos commit, because this will cause flakes (instead of fails) if we get it wrong. Better have a deterministic fail mode. Signed-off-by: Alyssa Rosenzweig Part-of: --- .../bifrost/valhall/test/test-insert-flow.cpp | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/src/panfrost/bifrost/valhall/test/test-insert-flow.cpp b/src/panfrost/bifrost/valhall/test/test-insert-flow.cpp index 57b547d7c9b..410fe4ec1b6 100644 --- a/src/panfrost/bifrost/valhall/test/test-insert-flow.cpp +++ b/src/panfrost/bifrost/valhall/test/test-insert-flow.cpp @@ -248,3 +248,16 @@ TEST_F(InsertFlow, DiamondCFG) { flow(END); }); } + +TEST_F(InsertFlow, BarrierBug) { + CASE(KERNEL, { + bi_instr *I = bi_store_i32(b, bi_register(0), bi_register(2), bi_register(4), BI_SEG_NONE, 0); + I->slot = 2; + + bi_fadd_f32_to(b, bi_register(10), bi_register(10), bi_register(10)); + flow(WAIT2); + bi_barrier(b); + flow(WAIT); + flow(END); + }); +}