From 433a0422d5553e6bf229be0c11513932fa29a3ee Mon Sep 17 00:00:00 2001
From: "Juan A. Suarez Romero" <jasuarez@igalia.com>
Date: Tue, 16 Jul 2024 09:24:19 +0200
Subject: [PATCH] v3dv: don't leak cache key
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

The hashtable stores a hash generated from the key, so there is no need
to duplicate the key, as otherwise it is a leak.

Found through address sanitizer.

Reviewed-by: Alejandro Piñeiro <apinheiro@igalia.com>
Reviewed-by: Iago Toral Quiroga <itoral@igalia.com>
Signed-off-by: Juan A. Suarez Romero <jasuarez@igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/30204>
---
 src/broadcom/vulkan/v3dv_meta_copy.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/broadcom/vulkan/v3dv_meta_copy.c b/src/broadcom/vulkan/v3dv_meta_copy.c
index 429509ac479..d57f29eac34 100644
--- a/src/broadcom/vulkan/v3dv_meta_copy.c
+++ b/src/broadcom/vulkan/v3dv_meta_copy.c
@@ -2536,10 +2536,8 @@ get_copy_texel_buffer_pipeline(
       goto fail;
 
    if (device->instance->meta_cache_enabled) {
-      uint8_t *dupkey = malloc(V3DV_META_TEXEL_BUFFER_COPY_CACHE_KEY_SIZE);
-      memcpy(dupkey, key, V3DV_META_TEXEL_BUFFER_COPY_CACHE_KEY_SIZE);
       _mesa_hash_table_insert(device->meta.texel_buffer_copy.cache[image_type],
-                              dupkey, *pipeline);
+                              key, *pipeline);
       mtx_unlock(&device->meta.mtx);
    } else {
       v3dv_cmd_buffer_add_private_obj(