From 3cbd4fb61bcec79f0fca150f303c79a44804b565 Mon Sep 17 00:00:00 2001 From: Jesse Natalie Date: Fri, 7 Apr 2023 16:54:03 -0700 Subject: [PATCH] dzn: Don't enable bindless by default There's bad interactions with dynamic buffers at this point: * Perf issues due to allocating and freeing the buffer to store indices/offsets * Large dynamic uniform buffer offsets (above 65K) cause out-of-bounds reads Part-of: --- src/microsoft/vulkan/dzn_device.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/src/microsoft/vulkan/dzn_device.c b/src/microsoft/vulkan/dzn_device.c index 15a7a699a33..3c5d4ce0864 100644 --- a/src/microsoft/vulkan/dzn_device.c +++ b/src/microsoft/vulkan/dzn_device.c @@ -2421,12 +2421,6 @@ dzn_device_create(struct dzn_physical_device *pdev, device->support_static_samplers = true; device->bindless = (instance->debug_flags & DZN_DEBUG_BINDLESS) != 0 || -#if D3D12_SDK_VERSION >= 610 - /* Enable bindless by default when we can do it and still be in-spec, this is - * likely to be more efficient than the "bindful" method of copying descriptors. */ - (pdev->options19.MaxSamplerDescriptorHeapSize >= 4000 && - pdev->shader_model >= D3D_SHADER_MODEL_6_6) || -#endif device->vk.enabled_features.descriptorIndexing || device->vk.enabled_extensions.EXT_descriptor_indexing;