From 3c7f1feebf5e46377df86801d2b3f74004501d97 Mon Sep 17 00:00:00 2001 From: Sagar Ghuge Date: Sat, 4 Mar 2023 13:41:54 -0800 Subject: [PATCH] intel/compiler: Add helper method to decide if header is required v2: (Ian) - Return immediately from the switch case Reviewed-by: Ian Romanick Signed-off-by: Sagar Ghuge Part-of: --- .../compiler/brw_lower_logical_sends.cpp | 19 ++++++++++++++++--- 1 file changed, 16 insertions(+), 3 deletions(-) diff --git a/src/intel/compiler/brw_lower_logical_sends.cpp b/src/intel/compiler/brw_lower_logical_sends.cpp index a1b49a7bb48..5415566ebeb 100644 --- a/src/intel/compiler/brw_lower_logical_sends.cpp +++ b/src/intel/compiler/brw_lower_logical_sends.cpp @@ -956,6 +956,21 @@ emit_load_payload_with_padding(const fs_builder &bld, const fs_reg &dst, return inst; } +static bool +shader_opcode_needs_header(opcode op) +{ + switch (op) { + case SHADER_OPCODE_TG4: + case SHADER_OPCODE_TG4_OFFSET: + case SHADER_OPCODE_SAMPLEINFO: + return true; + default: + break; + } + + return false; +} + static void lower_sampler_logical_send_gfx7(const fs_builder &bld, fs_inst *inst, opcode op, const fs_reg &coordinate, @@ -992,9 +1007,7 @@ lower_sampler_logical_send_gfx7(const fs_builder &bld, fs_inst *inst, opcode op, assert((surface.file == BAD_FILE) != (surface_handle.file == BAD_FILE)); assert((sampler.file == BAD_FILE) != (sampler_handle.file == BAD_FILE)); - if (op == SHADER_OPCODE_TG4 || op == SHADER_OPCODE_TG4_OFFSET || - inst->offset != 0 || inst->eot || - op == SHADER_OPCODE_SAMPLEINFO || + if (shader_opcode_needs_header(op) || inst->offset != 0 || inst->eot || sampler_handle.file != BAD_FILE || is_high_sampler(devinfo, sampler) || residency) {