From 39c4de7e42a85a6871c552c2d55ddb7d3a1988ee Mon Sep 17 00:00:00 2001 From: Sviatoslav Peleshko Date: Thu, 2 May 2024 06:27:37 +0300 Subject: [PATCH] anv: Fix descriptor sampler offsets assignment This seems to be a simple copy-paste mistake. It makes sense to or-assign surface offsets because we clear the actual offset part with a mask first, but sampler offsets should be just assigned instead. Fixes: 7c76125d ("anv: use 2 different buffers for surfaces/samplers in descriptor sets") Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/10790 Signed-off-by: Sviatoslav Peleshko Reviewed-by: Lionel Landwerlin Part-of: --- src/intel/vulkan/anv_cmd_buffer.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/intel/vulkan/anv_cmd_buffer.c b/src/intel/vulkan/anv_cmd_buffer.c index 25a79f3e52f..41d5cf4ecfa 100644 --- a/src/intel/vulkan/anv_cmd_buffer.c +++ b/src/intel/vulkan/anv_cmd_buffer.c @@ -866,7 +866,7 @@ anv_cmd_buffer_bind_descriptor_set(struct anv_cmd_buffer *cmd_buffer, assert((offset & ~ANV_DESCRIPTOR_SET_OFFSET_MASK) == 0); push->desc_surface_offsets[set_index] &= ~ANV_DESCRIPTOR_SET_OFFSET_MASK; push->desc_surface_offsets[set_index] |= offset; - push->desc_sampler_offsets[set_index] |= + push->desc_sampler_offsets[set_index] = anv_address_physical(set->desc_sampler_addr) - cmd_buffer->device->physical->va.dynamic_state_pool.addr;