From 37016468a5296a4591c99bff0086f6f4eaee3354 Mon Sep 17 00:00:00 2001 From: Matt Turner Date: Tue, 20 May 2025 14:18:02 -0400 Subject: [PATCH] intel/compiler: Align human-readable send message info This fprintf() was added in commit cce3bea2a71 ("i965/disasm: Align send instruction meta-information with dst.")) to align the human-readable send message info (e.g. "render MsgDesc: RT write ...") with the destination register on the previous line. Two months later we disabled printing the instruction offset in commit 662f1ccc248 ("i965: Disable hex offset printing in disassembly."), thereby unaligning the human-readable send message info for the next 11 years. Part-of: --- src/intel/compiler/brw_disasm.c | 1 - src/intel/compiler/elk/elk_disasm.c | 1 - 2 files changed, 2 deletions(-) diff --git a/src/intel/compiler/brw_disasm.c b/src/intel/compiler/brw_disasm.c index dd23be6b701..c218786a24f 100644 --- a/src/intel/compiler/brw_disasm.c +++ b/src/intel/compiler/brw_disasm.c @@ -2186,7 +2186,6 @@ brw_disassemble_inst(FILE *file, const struct brw_isa_info *isa, pad(file, 16); space = 0; - fprintf(file, " "); err |= control(file, "SFID", brw_sfid, sfid, &space); string(file, " MsgDesc:"); diff --git a/src/intel/compiler/elk/elk_disasm.c b/src/intel/compiler/elk/elk_disasm.c index 68c4a6f5a2d..df311726adf 100644 --- a/src/intel/compiler/elk/elk_disasm.c +++ b/src/intel/compiler/elk/elk_disasm.c @@ -1689,7 +1689,6 @@ elk_disassemble_inst(FILE *file, const struct elk_isa_info *isa, pad(file, 16); space = 0; - fprintf(file, " "); err |= control(file, "SFID", devinfo->ver >= 6 ? gfx6_sfid : gfx4_sfid, sfid, &space); string(file, " MsgDesc:");