From 3514b65c358e0fe40613ecc46cea041073076433 Mon Sep 17 00:00:00 2001 From: Vinson Lee Date: Thu, 2 Jan 2025 17:30:36 -0800 Subject: [PATCH] hk: Fix hk_ia_update arguments order Fix defect reported by Coverity Scan. Arguments in wrong order (SWAPPED_ARGUMENTS) swapped_arguments: The positions of arguments in the call to hk_ia_update do not match the ordering of the parameters:stat_c_inv is passed to c_prims.stat_c_prims is passed to c_inv. Fixes: a3b796ba190b ("libagx,hk: handle pipeline stats queries without a GS") Signed-off-by: Vinson Lee Part-of: --- src/asahi/vulkan/hk_cmd_draw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/asahi/vulkan/hk_cmd_draw.c b/src/asahi/vulkan/hk_cmd_draw.c index a4652af1db1..0a0bab8ca45 100644 --- a/src/asahi/vulkan/hk_cmd_draw.c +++ b/src/asahi/vulkan/hk_cmd_draw.c @@ -3438,7 +3438,7 @@ hk_draw(struct hk_cmd_buffer *cmd, uint16_t draw_id, struct agx_draw draw_) if (ia_stats) { hk_ia_update(cmd, ccs, draw, stat_ia_verts, stat_ia_prims, stat_vs_inv, - stat_c_inv, stat_c_prims); + stat_c_prims, stat_c_inv); } if (tess) {