From 322c89e9fabdcde6599f34b5a2f16a8f1619fd18 Mon Sep 17 00:00:00 2001 From: Erik Faye-Lund Date: Thu, 19 Sep 2024 15:43:16 +0200 Subject: [PATCH] panvk: implement KHR_get_memory_requirements2 The rest is already in place, it seems. Reviewed-by: Boris Brezillon Part-of: --- docs/features.txt | 2 +- src/panfrost/vulkan/panvk_image.c | 3 ++- src/panfrost/vulkan/panvk_physical_device.c | 1 + 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/features.txt b/docs/features.txt index 61192fd523b..a687f84657a 100644 --- a/docs/features.txt +++ b/docs/features.txt @@ -439,7 +439,7 @@ Vulkan 1.1 -- all DONE: anv, lvp, nvk, radv, tu, vn VK_KHR_external_memory_capabilities DONE (anv, dzn, hasvk, lvp, nvk, pvr, radv, tu, v3dv, vn) VK_KHR_external_semaphore DONE (anv, dzn, hasvk, lvp, nvk, pvr, radv, tu, v3dv, vn) VK_KHR_external_semaphore_capabilities DONE (anv, dzn, hasvk, lvp, nvk, pvr, radv, tu, v3dv, vn) - VK_KHR_get_memory_requirements2 DONE (anv, dzn, hasvk, lvp, nvk, pvr, radv, tu, v3dv, vn) + VK_KHR_get_memory_requirements2 DONE (anv, dzn, hasvk, lvp, nvk, panvk, pvr, radv, tu, v3dv, vn) VK_KHR_get_physical_device_properties2 DONE (anv, dzn, hasvk, lvp, nvk, panvk, pvr, radv, tu, v3dv, vn) VK_KHR_maintenance1 DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) VK_KHR_maintenance2 DONE (anv, dzn, hasvk, lvp, nvk, radv, tu, v3dv, vn) diff --git a/src/panfrost/vulkan/panvk_image.c b/src/panfrost/vulkan/panvk_image.c index b9c96e9faca..8760df518aa 100644 --- a/src/panfrost/vulkan/panvk_image.c +++ b/src/panfrost/vulkan/panvk_image.c @@ -383,7 +383,8 @@ panvk_GetImageSparseMemoryRequirements2( uint32_t *pSparseMemoryRequirementCount, VkSparseImageMemoryRequirements2 *pSparseMemoryRequirements) { - panvk_stub(); + /* Sparse images are not yet supported. */ + *pSparseMemoryRequirementCount = 0; } VKAPI_ATTR VkResult VKAPI_CALL diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index b7988a06313..79c476a731a 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -68,6 +68,7 @@ get_device_extensions(const struct panvk_physical_device *device, .KHR_device_group = true, .KHR_descriptor_update_template = true, .KHR_driver_properties = true, + .KHR_get_memory_requirements2 = true, .KHR_maintenance3 = true, .KHR_pipeline_executable_properties = true, .KHR_pipeline_library = true,