From 30e32c9c78c45e3f39f43bc0b3d8a235f10369f1 Mon Sep 17 00:00:00 2001 From: Rob Clark Date: Thu, 18 Sep 2025 14:28:49 -0700 Subject: [PATCH] freedreno/registers: Rename some unknowns Signed-off-by: Rob Clark Part-of: --- src/freedreno/common/freedreno_dev_info.h | 2 +- src/freedreno/common/freedreno_devices.py | 66 +++++++++---------- src/freedreno/registers/adreno/a6xx.xml | 25 +++++-- src/freedreno/tests/reference/crash.log | 6 +- .../tests/reference/crash_prefetch.log | 12 ++-- ...exed.indirect_draw_count.triangle_list.log | 6 +- src/freedreno/tests/reference/fd-clouds.log | 6 +- .../tests/reference/prefetch-test.log | 8 +-- src/freedreno/vulkan/tu_cmd_buffer.cc | 4 +- .../drivers/freedreno/a6xx/fd6_emit.cc | 2 +- 10 files changed, 77 insertions(+), 60 deletions(-) diff --git a/src/freedreno/common/freedreno_dev_info.h b/src/freedreno/common/freedreno_dev_info.h index d168d1825e2..9c14c7bdd36 100644 --- a/src/freedreno/common/freedreno_dev_info.h +++ b/src/freedreno/common/freedreno_dev_info.h @@ -237,7 +237,7 @@ struct fd_dev_info { uint32_t RB_DBG_ECO_CNTL; uint32_t RB_DBG_ECO_CNTL_blit; uint32_t HLSQ_DBG_ECO_CNTL; - uint32_t RB_UNKNOWN_8E01; + uint32_t RB_RBP_CNTL; uint32_t VPC_DBG_ECO_CNTL; uint32_t UCHE_UNKNOWN_0E12; diff --git a/src/freedreno/common/freedreno_devices.py b/src/freedreno/common/freedreno_devices.py index a467ca9ee35..b7a8573db36 100644 --- a/src/freedreno/common/freedreno_devices.py +++ b/src/freedreno/common/freedreno_devices.py @@ -473,7 +473,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0, - RB_UNKNOWN_8E01 = 0x00000001, + RB_RBP_CNTL = 0x00000001, VPC_DBG_ECO_CNTL = 0x0, UCHE_UNKNOWN_0E12 = 0x10000000, ), @@ -507,7 +507,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x00080000, - RB_UNKNOWN_8E01 = 0x00000001, + RB_RBP_CNTL = 0x00000001, VPC_DBG_ECO_CNTL = 0x0, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -536,7 +536,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -567,7 +567,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -598,7 +598,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x05100000, HLSQ_DBG_ECO_CNTL = 0x00080000, - RB_UNKNOWN_8E01 = 0x00000001, + RB_RBP_CNTL = 0x00000001, VPC_DBG_ECO_CNTL = 0x0, UCHE_UNKNOWN_0E12 = 0x10000001 ) @@ -629,7 +629,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x00000001, + RB_RBP_CNTL = 0x00000001, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -660,7 +660,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x00000001, + RB_RBP_CNTL = 0x00000001, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -691,7 +691,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -727,7 +727,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -757,7 +757,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -787,7 +787,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x04100000, RB_DBG_ECO_CNTL_blit = 0x04100000, HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000001 ) @@ -818,7 +818,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x100000, RB_DBG_ECO_CNTL_blit = 0x00100000, # ??? HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x2000400, UCHE_UNKNOWN_0E12 = 0x00000001 ), @@ -866,7 +866,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x100000, RB_DBG_ECO_CNTL_blit = 0x100000, HLSQ_DBG_ECO_CNTL = 0x02000000, - RB_UNKNOWN_8E01 = 0x1, + RB_RBP_CNTL = 0x1, VPC_DBG_ECO_CNTL = 0x0, UCHE_UNKNOWN_0E12 = 0x1, ), @@ -984,7 +984,7 @@ a730_magic_regs = dict( SP_DBG_ECO_CNTL = 0x10000000, RB_DBG_ECO_CNTL = 0x00000000, RB_DBG_ECO_CNTL_blit = 0x00000000, # is it even needed? - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x3200000, @@ -1004,10 +1004,10 @@ a730_raw_magic_regs = [ [A6XXRegs.REG_A6XX_PC_DBG_ECO_CNTL, 0x20080000], [A6XXRegs.REG_A7XX_PC_UNKNOWN_9E24, 0x21fc7f00], [A6XXRegs.REG_A7XX_VFD_DBG_ECO_CNTL, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE06, 0x00000000], + [A6XXRegs.REG_A7XX_SP_ISDB_CNTL, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6A, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6B, 0x00000080], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE73, 0x00000000], + [A6XXRegs.REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, 0x00000080], + [A6XXRegs.REG_A7XX_SP_HLSQ_DBG_ECO_CNTL_1, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB02, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB01, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB22, 0x00000000], @@ -1039,7 +1039,7 @@ a740_magic_regs = dict( RB_DBG_ECO_CNTL = 0x00000000, RB_DBG_ECO_CNTL_blit = 0x00000000, # is it even needed? # HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000000, @@ -1059,10 +1059,10 @@ a740_raw_magic_regs = [ [A6XXRegs.REG_A6XX_PC_DBG_ECO_CNTL, 0x00100000], [A6XXRegs.REG_A7XX_PC_UNKNOWN_9E24, 0x21585600], [A6XXRegs.REG_A7XX_VFD_DBG_ECO_CNTL, 0x00008000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE06, 0x00000000], + [A6XXRegs.REG_A7XX_SP_ISDB_CNTL, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6A, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6B, 0x00000080], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE73, 0x00000000], + [A6XXRegs.REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, 0x00000080], + [A6XXRegs.REG_A7XX_SP_HLSQ_DBG_ECO_CNTL_1, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB02, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB01, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB22, 0x00000000], @@ -1141,7 +1141,7 @@ add_gpus([ SP_DBG_ECO_CNTL = 0x10000000, RB_DBG_ECO_CNTL = 0x00000001, RB_DBG_ECO_CNTL_blit = 0x00000001, # is it even needed? - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000000, @@ -1160,10 +1160,10 @@ add_gpus([ [A6XXRegs.REG_A6XX_PC_DBG_ECO_CNTL, 0x00100000], [A6XXRegs.REG_A7XX_PC_UNKNOWN_9E24, 0x01585600], [A6XXRegs.REG_A7XX_VFD_DBG_ECO_CNTL, 0x00008000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE06, 0x00000000], + [A6XXRegs.REG_A7XX_SP_ISDB_CNTL, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6A, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6B, 0x00000080], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE73, 0x00000000], + [A6XXRegs.REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, 0x00000080], + [A6XXRegs.REG_A7XX_SP_HLSQ_DBG_ECO_CNTL_1, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB02, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB01, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB22, 0x00000000], @@ -1232,10 +1232,10 @@ add_gpus([ [A6XXRegs.REG_A6XX_PC_DBG_ECO_CNTL, 0x00100000], [A6XXRegs.REG_A7XX_PC_UNKNOWN_9E24, 0x21585600], [A6XXRegs.REG_A7XX_VFD_DBG_ECO_CNTL, 0x00008000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE06, 0x00000000], + [A6XXRegs.REG_A7XX_SP_ISDB_CNTL, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6A, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6B, 0x00000080], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE73, 0x00000000], + [A6XXRegs.REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, 0x00000080], + [A6XXRegs.REG_A7XX_SP_HLSQ_DBG_ECO_CNTL_1, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB02, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB01, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB22, 0x00000000], @@ -1281,7 +1281,7 @@ add_gpus([ RB_DBG_ECO_CNTL = 0x00000001, RB_DBG_ECO_CNTL_blit = 0x00000000, # is it even needed? # HLSQ_DBG_ECO_CNTL = 0x0, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x00000000, @@ -1312,7 +1312,7 @@ add_gpus([ SP_DBG_ECO_CNTL = 0x10000000, RB_DBG_ECO_CNTL = 0x00000001, RB_DBG_ECO_CNTL_blit = 0x00000001, - RB_UNKNOWN_8E01 = 0x0, + RB_RBP_CNTL = 0x0, VPC_DBG_ECO_CNTL = 0x02000000, UCHE_UNKNOWN_0E12 = 0x40000000, @@ -1329,10 +1329,10 @@ add_gpus([ [A6XXRegs.REG_A6XX_PC_DBG_ECO_CNTL, 0x00100000], [A6XXRegs.REG_A7XX_PC_UNKNOWN_9E24, 0x01585600], [A6XXRegs.REG_A7XX_VFD_DBG_ECO_CNTL, 0x00008000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE06, 0x00000000], + [A6XXRegs.REG_A7XX_SP_ISDB_CNTL, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6A, 0x00000000], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE6B, 0x00000080], - [A6XXRegs.REG_A7XX_SP_UNKNOWN_AE73, 0x00000000], + [A6XXRegs.REG_A7XX_SP_HLSQ_TIMEOUT_THRESHOLD_DP, 0x00000080], + [A6XXRegs.REG_A7XX_SP_HLSQ_DBG_ECO_CNTL_1, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB02, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB01, 0x00000000], [A6XXRegs.REG_A7XX_SP_UNKNOWN_AB22, 0x00000000], diff --git a/src/freedreno/registers/adreno/a6xx.xml b/src/freedreno/registers/adreno/a6xx.xml index 4e212ab08e9..7ff207319be 100644 --- a/src/freedreno/registers/adreno/a6xx.xml +++ b/src/freedreno/registers/adreno/a6xx.xml @@ -1928,7 +1928,7 @@ by a particular renderpass/blit. - + @@ -2437,6 +2437,8 @@ by a particular renderpass/blit. + + Written by CP_SET_VISIBILITY_OVERRIDE handler @@ -3251,10 +3253,12 @@ by a particular renderpass/blit. - + + + + + + + + + + + + + + +