From 28e2d9088cd1f12805aa432b7ca64aee301c7300 Mon Sep 17 00:00:00 2001 From: Benjamin Lee Date: Wed, 5 Feb 2025 13:45:29 -0800 Subject: [PATCH] panvk: enable uniformAndStorageBuffer8BitAccess and storagePushConstant8 8-bit loads are already supported by bi_emit_load_ubo and bi_emit_load_push_constant, so the only necessary changes were fixing swizzle lowering issues uncovered by these CTS tests. Signed-off-by: Benjamin Lee Reviewed-by: Eric R. Smith Part-of: --- docs/relnotes/new_features.txt | 2 ++ src/panfrost/vulkan/panvk_physical_device.c | 4 ++-- 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/docs/relnotes/new_features.txt b/docs/relnotes/new_features.txt index b4717cf3685..d447904cf7d 100644 --- a/docs/relnotes/new_features.txt +++ b/docs/relnotes/new_features.txt @@ -32,3 +32,5 @@ VK_EXT_sample_locations on RADV for GFX10+ GL_ARB_shader_clock on panvk VK_KHR_float_controls on panvk VK_KHR_float_controls2 on panvk +storageBuffer8BitAccess on panvk +uniformAndStorageBuffer8BitAccess on panvk diff --git a/src/panfrost/vulkan/panvk_physical_device.c b/src/panfrost/vulkan/panvk_physical_device.c index 570eb3d0adf..e1373baea47 100644 --- a/src/panfrost/vulkan/panvk_physical_device.c +++ b/src/panfrost/vulkan/panvk_physical_device.c @@ -399,8 +399,8 @@ get_features(const struct panvk_physical_device *device, .samplerMirrorClampToEdge = true, .drawIndirectCount = false, .storageBuffer8BitAccess = true, - .uniformAndStorageBuffer8BitAccess = false, - .storagePushConstant8 = false, + .uniformAndStorageBuffer8BitAccess = true, + .storagePushConstant8 = true, .shaderBufferInt64Atomics = false, .shaderSharedInt64Atomics = false, .shaderFloat16 = arch >= 10,