From 2897a83ff8d4b5af15ef333c769428cf5ae652ba Mon Sep 17 00:00:00 2001 From: Iago Toral Quiroga Date: Tue, 2 Mar 2021 15:37:30 +0100 Subject: [PATCH] broadcom/compiler: drop the destination for unused ldunifa MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit We can't remove unused ldunifa that are not the first or last in a sequence, but we can still ignore their destination to reduce register pressure. Reviewed-by: Alejandro Piñeiro Part-of: --- src/broadcom/compiler/vir_opt_dead_code.c | 24 ++++++++++++++--------- 1 file changed, 15 insertions(+), 9 deletions(-) diff --git a/src/broadcom/compiler/vir_opt_dead_code.c b/src/broadcom/compiler/vir_opt_dead_code.c index b40b25b20c0..55469402e7a 100644 --- a/src/broadcom/compiler/vir_opt_dead_code.c +++ b/src/broadcom/compiler/vir_opt_dead_code.c @@ -209,16 +209,21 @@ vir_opt_dead_code(struct v3d_compile *c) continue; } - const bool is_last_ldunifa = - check_last_ldunifa(c, inst, block); + const bool is_ldunifa = inst->qpu.sig.ldunifa || + inst->qpu.sig.ldunifarf; - struct qinst *unifa = NULL; - const bool is_first_ldunifa = - check_first_ldunifa(c, inst, block, &unifa); - - if (vir_has_side_effects(c, inst) && - !is_last_ldunifa && !is_first_ldunifa) { + if (vir_has_side_effects(c, inst) && !is_ldunifa) continue; + + bool is_first_ldunifa = false; + bool is_last_ldunifa = false; + struct qinst *unifa = NULL; + if (is_ldunifa) { + is_last_ldunifa = + check_last_ldunifa(c, inst, block); + + is_first_ldunifa = + check_first_ldunifa(c, inst, block, &unifa); } if (v3d_qpu_writes_flags(&inst->qpu)) { @@ -236,7 +241,8 @@ vir_opt_dead_code(struct v3d_compile *c) } if (v3d_qpu_writes_flags(&inst->qpu) || - has_nonremovable_reads(c, inst)) { + has_nonremovable_reads(c, inst) || + (is_ldunifa && !is_first_ldunifa && !is_last_ldunifa)) { /* If we can't remove the instruction, but we * don't need its destination value, just * remove the destination. The register