glsl: Add parser/compiler support for unsized array's length()
The unsized array length is computed with the following formula: array.length() = max((buffer_object_size - offset_of_array) / stride_of_array, 0) Of these, only the buffer size needs to be provided by the backends, the frontend already knows the values of the two other variables. This patch identifies the cases where we need to get the length of an unsized array, injecting ir_unop_ssbo_unsized_array_length expressions that will be lowered (in a later patch) to inject the formula mentioned above. It also adds the ir_unop_get_buffer_size expression that drivers will implement to provide the buffer length. v2: - Do not define a triop that will force backends to implement the entire formula, they should only need to provide the buffer size since the other values are known by the frontend (Curro). v3: - Call state->has_shader_storage_buffer_objects() in ast_function.cpp instead of using state->ARB_shader_storage_buffer_object_enable (Tapani). Signed-off-by: Samuel Iglesias Gonsalvez <siglesias@igalia.com> Reviewed-by: Kristian Høgsberg <krh@bitplanet.net>
This commit is contained in:
@@ -1593,11 +1593,16 @@ ast_function_expression::handle_method(exec_list *instructions,
|
||||
|
||||
if (op->type->is_array()) {
|
||||
if (op->type->is_unsized_array()) {
|
||||
_mesa_glsl_error(&loc, state, "length called on unsized array");
|
||||
goto fail;
|
||||
if (!state->has_shader_storage_buffer_objects()) {
|
||||
_mesa_glsl_error(&loc, state, "length called on unsized array"
|
||||
" only available with "
|
||||
"ARB_shader_storage_buffer_object");
|
||||
}
|
||||
/* Calculate length of an unsized array in run-time */
|
||||
result = new(ctx) ir_expression(ir_unop_ssbo_unsized_array_length, op);
|
||||
} else {
|
||||
result = new(ctx) ir_constant(op->type->array_size());
|
||||
}
|
||||
|
||||
result = new(ctx) ir_constant(op->type->array_size());
|
||||
} else if (op->type->is_vector()) {
|
||||
if (state->ARB_shading_language_420pack_enable) {
|
||||
/* .length() returns int. */
|
||||
|
||||
Reference in New Issue
Block a user